From: Helge Deller <deller@gmx.de>
To: Lucy Mielke <mielkesteven@icloud.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] fbdev: omapfb: cleanup inconsistent indentation
Date: Sat, 25 Feb 2023 18:23:48 +0100 [thread overview]
Message-ID: <eb6900d5-148f-85cb-eebc-c20d99802c75@gmx.de> (raw)
In-Reply-To: <20230207100630.11644-1-mielkesteven@icloud.com>
Hi Lucy,
On 2/7/23 11:06, Lucy Mielke wrote:
> This cleans up the indentation according to the Linux kernel coding
> style, and should fix the warning created by the kernel test robot.
>
> Fixes: 8b08cf2b64f5a60594b07795b2ad518c6d044566 ("OMAP: add TI OMAP
> framebuffer driver")
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lucy Mielke <mielkesteven@icloud.com>
> ---
> drivers/video/fbdev/omap/omapfb_main.c | 32 +++++++++++++++-----------
> 1 file changed, 19 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index 1f3df2055ff0..4b673daa32cb 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -78,7 +78,7 @@ static struct platform_device omapdss_device = {
> .name = "omapdss_dss",
> .id = -1,
> .dev = {
> - .release = omapdss_release,
> + .release = omapdss_release,> },
This is wrong. "release" belongs inside the .dev
variable, so the previous indenting is correct.
The changes below seem correct.
Helge
> };
>
> @@ -544,19 +544,25 @@ static int set_fb_var(struct fb_info *fbi,
> var->yoffset = var->yres_virtual - var->yres;
>
> if (plane->color_mode == OMAPFB_COLOR_RGB444) {
> - var->red.offset = 8; var->red.length = 4;
> - var->red.msb_right = 0;
> - var->green.offset = 4; var->green.length = 4;
> - var->green.msb_right = 0;
> - var->blue.offset = 0; var->blue.length = 4;
> - var->blue.msb_right = 0;
> + var->red.offset = 8;
> + var->red.length = 4;
> + var->red.msb_right = 0;
> + var->green.offset = 4;
> + var->green.length = 4;
> + var->green.msb_right = 0;
> + var->blue.offset = 0;
> + var->blue.length = 4;
> + var->blue.msb_right = 0;
> } else {
> - var->red.offset = 11; var->red.length = 5;
> - var->red.msb_right = 0;
> - var->green.offset = 5; var->green.length = 6;
> - var->green.msb_right = 0;
> - var->blue.offset = 0; var->blue.length = 5;
> - var->blue.msb_right = 0;
> + var->red.offset = 11;
> + var->red.length = 5;
> + var->red.msb_right = 0;
> + var->green.offset = 5;
> + var->green.length = 6;
> + var->green.msb_right = 0;
> + var->blue.offset = 0;
> + var->blue.length = 5;
> + var->blue.msb_right = 0;
> }
>
> var->height = -1;
next prev parent reply other threads:[~2023-02-25 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 10:06 [PATCH] fbdev: omapfb: cleanup inconsistent indentation Lucy Mielke
2023-02-25 17:23 ` Helge Deller [this message]
2023-02-25 18:10 ` Helge Deller
-- strict thread matches above, loose matches on Subject: below --
2023-02-07 9:36 Lucy Mielke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb6900d5-148f-85cb-eebc-c20d99802c75@gmx.de \
--to=deller@gmx.de \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mielkesteven@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).