From: Takashi Iwai <tiwai@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Russell King <linux@armlinux.org.uk>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org,
dri-devel@lists.freedesktop.org, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
kvm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 4/5] amba: Make the remove callback return void
Date: Wed, 27 Jan 2021 07:50:23 +0100 [thread overview]
Message-ID: <s5hlfcezxe8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210126165835.687514-5-u.kleine-koenig@pengutronix.de>
On Tue, 26 Jan 2021 17:58:34 +0100,
Uwe Kleine-König wrote:
>
> All amba drivers return 0 in their remove callback. Together with the
> driver core ignoring the return value anyhow, it doesn't make sense to
> return a value here.
>
> Change the remove prototype to return void, which makes it explicit that
> returning an error value doesn't work as expected. This simplifies changing
> the core remove callback to return void, too.
>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # for drivers/memory
> Acked-by: Mark Brown <broonie@kernel.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/amba/bus.c | 5 ++---
> drivers/char/hw_random/nomadik-rng.c | 3 +--
> drivers/dma/pl330.c | 3 +--
> drivers/gpu/drm/pl111/pl111_drv.c | 4 +---
> drivers/hwtracing/coresight/coresight-catu.c | 3 +--
> drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 +---
> drivers/hwtracing/coresight/coresight-cti-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-etb10.c | 4 +---
> drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-funnel.c | 4 ++--
> drivers/hwtracing/coresight/coresight-replicator.c | 4 ++--
> drivers/hwtracing/coresight/coresight-stm.c | 4 +---
> drivers/hwtracing/coresight/coresight-tmc-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-tpiu.c | 4 +---
> drivers/i2c/busses/i2c-nomadik.c | 4 +---
> drivers/input/serio/ambakmi.c | 3 +--
> drivers/memory/pl172.c | 4 +---
> drivers/memory/pl353-smc.c | 4 +---
> drivers/mmc/host/mmci.c | 4 +---
> drivers/rtc/rtc-pl030.c | 4 +---
> drivers/rtc/rtc-pl031.c | 4 +---
> drivers/spi/spi-pl022.c | 5 ++---
> drivers/tty/serial/amba-pl010.c | 4 +---
> drivers/tty/serial/amba-pl011.c | 3 +--
> drivers/vfio/platform/vfio_amba.c | 3 +--
> drivers/video/fbdev/amba-clcd.c | 4 +---
> drivers/watchdog/sp805_wdt.c | 4 +---
> include/linux/amba/bus.h | 2 +-
> sound/arm/aaci.c | 4 +---
For the sound/*:
Acked-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2021-01-27 6:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 16:58 [PATCH v3 0/5] amba: minor fix and various cleanups Uwe Kleine-König
2021-01-26 16:58 ` [PATCH v3 4/5] amba: Make the remove callback return void Uwe Kleine-König
2021-01-26 17:08 ` Suzuki K Poulose
2021-01-26 17:56 ` Uwe Kleine-König
2021-01-26 19:05 ` Russell King - ARM Linux admin
2021-01-26 17:30 ` Vinod Koul
2021-01-26 19:24 ` Guenter Roeck
2021-01-27 6:47 ` Wolfram Sang
2021-01-27 6:50 ` Takashi Iwai [this message]
2021-01-27 8:12 ` Vladimir Zapolskiy
2021-01-27 12:03 ` Greg Kroah-Hartman
2021-02-03 13:18 ` Auger Eric
2021-02-02 10:49 ` [PATCH v3 0/5] amba: minor fix and various cleanups Russell King - ARM Linux admin
2021-02-03 7:45 ` Uwe Kleine-König
2021-02-02 13:53 ` [GIT PULL] immutable branch for amba changes targeting v5.12-rc1 Uwe Kleine-König
2021-02-02 14:06 ` Greg Kroah-Hartman
2021-02-04 16:52 ` Russell King - ARM Linux admin
2021-02-04 16:56 ` Greg Kroah-Hartman
2021-02-04 16:59 ` Russell King - ARM Linux admin
2021-02-04 18:15 ` Uwe Kleine-König
2021-02-05 9:37 ` Uwe Kleine-König
2021-02-05 10:18 ` Greg Kroah-Hartman
2021-02-05 10:56 ` Uwe Kleine-König
2021-02-05 11:07 ` Greg Kroah-Hartman
2021-02-02 19:43 ` [PATCH] mailbox: arm_mhuv2: make remove callback return void Uwe Kleine-König
2021-02-03 2:57 ` Viresh Kumar
2021-02-02 21:35 ` [GIT PULL] immutable branch for amba changes targeting v5.12-rc1 Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlfcezxe8.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=a.zummo@towertech.it \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cohuck@redhat.com \
--cc=coresight@lists.linaro.org \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.auger@redhat.com \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@linaro.org \
--cc=mpm@selenic.com \
--cc=perex@perex.cz \
--cc=suzuki.poulose@arm.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=vz@mleia.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).