From: Xu Yilun <yilun.xu@intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: "Wu, Hao" <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"lgoncalv@redhat.com" <lgoncalv@redhat.com>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
"Weight, Russell H" <russell.h.weight@intel.com>
Subject: Re: [PATCH 1/3] fpga: dfl: move dfl_device_id to mod_devicetable.h
Date: Tue, 15 Sep 2020 11:13:39 +0800 [thread overview]
Message-ID: <20200915031339.GC9950@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20200915031014.GB1827@epycbox.lan>
On Mon, Sep 14, 2020 at 08:10:14PM -0700, Moritz Fischer wrote:
> On Tue, Sep 15, 2020 at 10:55:17AM +0800, Xu Yilun wrote:
> > On Mon, Sep 14, 2020 at 02:32:32PM -0700, Moritz Fischer wrote:
> > > Hao,
> > >
> > > On Fri, Sep 11, 2020 at 06:50:18AM +0000, Wu, Hao wrote:
> > > > > On 9/10/20 1:41 AM, Xu Yilun wrote:
> > > > > > On Wed, Sep 09, 2020 at 05:55:33AM -0700, Tom Rix wrote:
> > > > > >> On 9/7/20 10:48 PM, Xu Yilun wrote:
> > > > > >>> In order to support MODULE_DEVICE_TABLE() for dfl device driver, this
> > > > > >>> patch moves struct dfl_device_id to mod_devicetable.h
> > > > > >>>
> > > > > >>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > > > >>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> > > > > >>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > >>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > > > > >>> ---
> > > > > >>> drivers/fpga/dfl.h | 13 +------------
> > > > > >>> include/linux/mod_devicetable.h | 12 ++++++++++++
> > > > > >>> 2 files changed, 13 insertions(+), 12 deletions(-)
> > > > > >>>
> > > > > >>> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> > > > > >>> index 5dc758f..d5b0760 100644
> > > > > >>> --- a/drivers/fpga/dfl.h
> > > > > >>> +++ b/drivers/fpga/dfl.h
> > > > > >>> @@ -26,6 +26,7 @@
> > > > > >>> #include <linux/slab.h>
> > > > > >>> #include <linux/uuid.h>
> > > > > >>> #include <linux/fpga/fpga-region.h>
> > > > > >>> +#include <linux/mod_devicetable.h>
> > > >
> > > > Please fix the order for the new one, other places to good to me.
> > > > Acked-by: Wu Hao <hao.wu@intel.com> for DFL related changes after this fix.
> > >
> > > Do you mean the order of the includes, like alphabeticized? If it's
> > > minor I can fix it up when applying.
> >
> > I think it is the alphabetic of head files. I could sent v2 patchset for
> > this fix as well as other fixes.
>
> Alright, works for me. Can you do that?
Yes, I'm working on it. :)
Thanks,
Yilun
>
> - Moritz
next prev parent reply other threads:[~2020-09-15 3:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1599544129-17594-1-git-send-email-yilun.xu@intel.com>
2020-09-08 5:48 ` [PATCH 1/3] fpga: dfl: move dfl_device_id to mod_devicetable.h Xu Yilun
2020-09-09 12:55 ` Tom Rix
2020-09-10 8:41 ` Xu Yilun
2020-09-10 13:32 ` Tom Rix
[not found] ` <DM6PR11MB3819E2EA499781899B7384F385240@DM6PR11MB3819.namprd11.prod.outlook.com>
2020-09-14 21:32 ` Moritz Fischer
2020-09-15 2:55 ` Xu Yilun
2020-09-15 3:10 ` Moritz Fischer
2020-09-15 3:13 ` Xu Yilun [this message]
2020-09-08 5:48 ` [PATCH 2/3] dfl: add dfl bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-09-09 12:58 ` Tom Rix
[not found] ` <1599544129-17594-4-git-send-email-yilun.xu@intel.com>
2020-09-09 13:12 ` [PATCH 3/3] fpga: dfl: move dfl-bus related APIs to include/linux/fpga/dfl-bus.h Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915031339.GC9950@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).