From: Xu Yilun <yilun.xu@intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, trix@redhat.com,
yilun.xu@intel.com
Subject: Re: [RESEND PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration
Date: Mon, 16 Nov 2020 15:10:23 +0800 [thread overview]
Message-ID: <20201116071023.GB8715@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20201115195127.284487-4-mdf@kernel.org>
Tested on DFL FPGA platform, it is OK.
Thanks,
Yilun
On Sun, Nov 15, 2020 at 11:51:20AM -0800, Moritz Fischer wrote:
> Simplify registration using new devm_fpga_mgr_register() API.
>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/dfl-fme-mgr.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c
> index b3f7eee3c93f..d5861d13b306 100644
> --- a/drivers/fpga/dfl-fme-mgr.c
> +++ b/drivers/fpga/dfl-fme-mgr.c
> @@ -314,18 +314,8 @@ static int fme_mgr_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> mgr->compat_id = compat_id;
> - platform_set_drvdata(pdev, mgr);
>
> - return fpga_mgr_register(mgr);
> -}
> -
> -static int fme_mgr_remove(struct platform_device *pdev)
> -{
> - struct fpga_manager *mgr = platform_get_drvdata(pdev);
> -
> - fpga_mgr_unregister(mgr);
> -
> - return 0;
> + return devm_fpga_mgr_register(dev, mgr);
> }
>
> static struct platform_driver fme_mgr_driver = {
> @@ -333,7 +323,6 @@ static struct platform_driver fme_mgr_driver = {
> .name = DFL_FPGA_FME_MGR,
> },
> .probe = fme_mgr_probe,
> - .remove = fme_mgr_remove,
> };
>
> module_platform_driver(fme_mgr_driver);
> --
> 2.29.2
next prev parent reply other threads:[~2020-11-16 7:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 19:51 [RESEND PATCH 00/10] Introduce devm_fpga_mgr_register() Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: " Moritz Fischer
2020-11-16 7:10 ` Xu Yilun [this message]
2020-11-15 19:51 ` [RESEND PATCH 04/10] fpga: fpga-mgr: ice40-spi: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 05/10] fpga: fpga-mgr: machxo2-spi: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 06/10] fpga: fpga-mgr: socfpga: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 07/10] fpga: fpga-mgr: ts73xx: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 08/10] fpga: fpga-mgr: xilinx-spi: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 09/10] fpga: fpga-mgr: zynqmp: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: " Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116071023.GB8715@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).