From: Xu Yilun <yilun.xu@intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: Tom Rix <trix@redhat.com>,
gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, lgoncalv@redhat.com,
hao.wu@intel.com
Subject: Re: [PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus
Date: Tue, 26 Jan 2021 10:40:05 +0800 [thread overview]
Message-ID: <20210126024005.GB3907@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <YA98/8r+yOCurHAJ@epycbox.lan>
On Mon, Jan 25, 2021 at 06:22:55PM -0800, Moritz Fischer wrote:
> On Mon, Jan 25, 2021 at 11:00:38AM -0800, Tom Rix wrote:
> >
> > On 1/25/21 12:49 AM, Xu Yilun wrote:
> > > This patch supports the DFL drivers be written in userspace. This is
> > > realized by exposing the userspace I/O device interfaces.
> > >
> > > The driver now only binds the ether group feature, which has no irq. So
> > > the irq support is not implemented yet.
> > >
> > > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > ---
> > > v9: switch to add a uio driver in drivers/uio
> > > ---
> > > drivers/uio/Kconfig | 13 ++++++++++
> > > drivers/uio/Makefile | 1 +
> > > drivers/uio/uio_dfl.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > You should add this to the MAINTAINERS file.
>
> This is covered by MAINTAINERS under drivers/uio.
Yes. But is it OK I also add the file in "FPGA DFL DRIVERS"? So DFL
developers would also be aware if there is change. It is a little
different from other feature driver, it is like a generic driver for
DFL bus.
> >
> > > 3 files changed, 80 insertions(+)
> > > create mode 100644 drivers/uio/uio_dfl.c
> > >
> > > diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
> > > index 202ee81..44778f8 100644
> > > --- a/drivers/uio/Kconfig
> > > +++ b/drivers/uio/Kconfig
> > > @@ -165,4 +165,17 @@ config UIO_HV_GENERIC
> > > to network and storage devices from userspace.
> > >
> > > If you compile this as a module, it will be called uio_hv_generic.
> > > +
> > > +config UIO_DFL
> > > + tristate "Generic driver for DFL bus"
> >
> > The term 'DFL' will be unknown to folks in drivers/uio
> >
> > I think it would be better if DFL was always prefixed 'FPGA DFL'
> >
> > > + depends on FPGA_DFL
> > > + help
> > > + Generic DFL (Device Feature List) driver for Userspace I/O devices.
> > > + It is useful to provide direct access to DFL devices from userspace.
> > > + A sample userspace application using this driver is available for
> > > + download in a git repository:
> > > +
> > > + git clone https://github.com/OPAE/opae-sdk.git
> > > +
> > > + If you compile this as a module, it will be called uio_dfl.
>
> I'm not sure KConfig is the right place for this.
Do you mean the OPAE link? I see several uio drivers provide their
userspace application link in Kconfig. I guess the uio drivers are
selected for these applications so it may be better pointing out where
they are.
Thanks,
Yilun
next prev parent reply other threads:[~2021-01-26 4:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 8:49 [PATCH v9 0/2] UIO support for dfl devices Xu Yilun
2021-01-25 8:49 ` [PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus Xu Yilun
2021-01-25 19:00 ` Tom Rix
2021-01-26 1:37 ` Xu Yilun
2021-01-26 2:22 ` Moritz Fischer
2021-01-26 2:40 ` Xu Yilun [this message]
2021-01-26 4:57 ` Moritz Fischer
2021-01-26 13:49 ` Tom Rix
2021-02-08 21:37 ` Tom Rix
2021-01-25 8:49 ` [PATCH v9 2/2] Documentation: fpga: dfl: Add description for DFL UIO support Xu Yilun
2021-01-25 16:52 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126024005.GB3907@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).