From: Russ Weight <russell.h.weight@intel.com>
To: mdf@kernel.org, linux-fpga@vger.kernel.org
Cc: trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com,
hao.wu@intel.com, matthew.gerlach@intel.com,
richard.gong@intel.com, Russ Weight <russell.h.weight@intel.com>
Subject: [PATCH v3 0/8] fpga: Populate dev_release functions
Date: Thu, 10 Jun 2021 12:34:14 -0700 [thread overview]
Message-ID: <20210610193422.286835-1-russell.h.weight@intel.com> (raw)
The FPGA framework has a convention of using managed resource functions
to allow parent drivers to manage the data structures allocated by the
class drivers. They use an empty *_dev_release() function to satisfy the
class driver.
This is inconsistent with linux driver model.
These changes populate the class dev_release callback functions while
maintaining the current API. Additional changes are made to maintain
consistency with the driver model.
For more context on these changes, refer to this email thread:
https://marc.info/?l=linux-fpga&m=162127412218557&w=2
Changelog v2 -> v3:
- Added Reviewed-by tags
- Moved a "dev" to "parent" rename in the comment header for
devm_fpga_region_create() from patch 8 to patch 5.
Changelog v1 -> v2:
- Moved the renaming of "dev" to "parent" into a separate patch each for
fpga-mgr, fpga-bridge, fpga-region.
- Restored the call to fpga_mgr_free() in devm_*_mgr_release() instead of
changing it to put_device().
- Replaced patch "fpga: altera-pr-ip: Remove function alt_pr_unregister"
with "fpga: altera-pr-ip: Remove function alt_pr_unregister". This patch
removes the alt_pr_unregister() function altogether, instead of just
removing portions of it.
Russ Weight (8):
fpga: altera-pr-ip: Remove function alt_pr_unregister
fpga: stratix10-soc: Add missing fpga_mgr_free() call
fpga: mgr: Rename dev to parent for parent device
fpga: bridge: Rename dev to parent for parent device
fpga: region: Rename dev to parent for parent device
fpga: mgr: Use standard dev_release for class driver
fpga: bridge: Use standard dev_release for class driver
fpga: region: Use standard dev_release for class driver
drivers/fpga/altera-pr-ip-core.c | 10 -----
drivers/fpga/fpga-bridge.c | 46 ++++++++++-----------
drivers/fpga/fpga-mgr.c | 55 ++++++++++++--------------
drivers/fpga/fpga-region.c | 44 ++++++++++-----------
drivers/fpga/stratix10-soc.c | 1 +
include/linux/fpga/altera-pr-ip-core.h | 1 -
6 files changed, 71 insertions(+), 86 deletions(-)
--
2.25.1
next reply other threads:[~2021-06-10 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 19:34 Russ Weight [this message]
2021-06-10 19:34 ` [PATCH v3 1/8] fpga: altera-pr-ip: Remove function alt_pr_unregister Russ Weight
2021-06-10 19:34 ` [PATCH v3 2/8] fpga: stratix10-soc: Add missing fpga_mgr_free() call Russ Weight
2021-06-10 19:34 ` [PATCH v3 3/8] fpga: mgr: Rename dev to parent for parent device Russ Weight
2021-06-10 19:34 ` [PATCH v3 4/8] fpga: bridge: " Russ Weight
2021-06-10 19:34 ` [PATCH v3 5/8] fpga: region: " Russ Weight
2021-06-10 19:34 ` [PATCH v3 6/8] fpga: mgr: Use standard dev_release for class driver Russ Weight
2021-06-10 19:34 ` [PATCH v3 7/8] fpga: bridge: " Russ Weight
2021-06-10 19:34 ` [PATCH v3 8/8] fpga: region: " Russ Weight
2021-06-10 19:38 ` [PATCH v3 0/8] fpga: Populate dev_release functions Russ Weight
2021-06-10 19:44 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610193422.286835-1-russell.h.weight@intel.com \
--to=russell.h.weight@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).