From: Russ Weight <russell.h.weight@intel.com>
To: Xu Yilun <yilun.xu@intel.com>
Cc: <mdf@kernel.org>, <linux-fpga@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <trix@redhat.com>,
<lgoncalv@redhat.com>, <hao.wu@intel.com>,
<matthew.gerlach@intel.com>
Subject: Re: [PATCH v16 2/5] fpga: image-load: enable image uploads
Date: Mon, 27 Sep 2021 09:33:43 -0700 [thread overview]
Message-ID: <5214232f-5cf2-d897-3f76-b72f48b9d512@intel.com> (raw)
In-Reply-To: <20210926011036.GB1339205@yilunxu-OptiPlex-7050>
On 9/25/21 6:10 PM, Xu Yilun wrote:
>>>>
>>>> + cdev_init(&imgld->cdev, &fpga_image_load_fops);
>>>> + imgld->cdev.owner = parent->driver->owner;
>>>> + imgld->cdev.kobj.parent = &imgld->dev.kobj;
>>> Could be replaced by cdev_set_parent()
> Sorry I ended last mail before this comment, and you may not notice it.
Yes - I did miss that. Thanks!
- Russ
>
> Thanks,
> Yilun
>
next prev parent reply other threads:[~2021-09-27 16:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 0:10 [PATCH v16 0/5] FPGA Image Load (previously Security Manager) Russ Weight
2021-09-23 0:10 ` [PATCH v16 1/5] fpga: image-load: fpga image load framework Russ Weight
2021-09-23 0:10 ` [PATCH v16 2/5] fpga: image-load: enable image uploads Russ Weight
2021-09-23 8:54 ` Xu Yilun
2021-09-24 0:21 ` Russ Weight
2021-09-24 8:12 ` Xu Yilun
2021-09-24 21:32 ` Russ Weight
2021-09-26 1:10 ` Xu Yilun
2021-09-27 16:33 ` Russ Weight [this message]
2021-09-23 0:10 ` [PATCH v16 3/5] fpga: image-load: signal eventfd when complete Russ Weight
2021-09-24 8:49 ` Xu Yilun
2021-09-24 21:45 ` Russ Weight
2021-09-26 1:06 ` Xu Yilun
2021-09-23 0:10 ` [PATCH v16 4/5] fpga: image-load: add status ioctl Russ Weight
2021-09-23 0:10 ` [PATCH v16 5/5] fpga: image-load: enable cancel of image upload Russ Weight
2021-09-24 14:53 ` Xu Yilun
2021-09-25 0:29 ` Russ Weight
2021-09-26 1:16 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214232f-5cf2-d897-3f76-b72f48b9d512@intel.com \
--to=russell.h.weight@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).