From: Moritz Fischer <mdf@kernel.org>
To: trix@redhat.com
Cc: hao.wu@intel.com, mdf@kernel.org, michal.simek@xilinx.com,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/7] fpga: wrappers for fpga_manager_ops
Date: Mon, 7 Jun 2021 14:59:06 -0700 [thread overview]
Message-ID: <YL6WqqUYHkhj+tEj@epycbox.lan> (raw)
In-Reply-To: <20210607172402.2938697-1-trix@redhat.com>
Hi Tom,
On Mon, Jun 07, 2021 at 10:23:55AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> As followup from
> https://lore.kernel.org/linux-fpga/06301910-10a1-0e62-45a0-d28ab5a787ed@redhat.com/
>
> Boards should not be required to have noop functions.
> So improve or create fpga-mgr wrappers for the fpga_manager_ops.
> Remove the noop functions.
> Refactor fpga-mgr to use the wrappers.
>
> write_sg op was not wrapped on purpose. Its checking / use in
> fpga_mgr_buf_load_sg() did not warrant a wrapper.
>
> Tom Rix (7):
> fpga: wrap the write_init() op
> fpga: make write_complete() op optional
> fpga: wrap the write() op
> fpga: wrap the status() op
> fpga: wrap the state() op
> fpga: wrap the fpga_remove() op
> fpga: collect wrappers and change to inline
>
> drivers/fpga/dfl-fme-mgr.c | 6 ---
> drivers/fpga/fpga-mgr.c | 102 +++++++++++++++++++++++------------
> drivers/fpga/stratix10-soc.c | 6 ---
> drivers/fpga/ts73xx-fpga.c | 6 ---
> drivers/fpga/zynqmp-fpga.c | 7 ---
> 5 files changed, 67 insertions(+), 60 deletions(-)
>
> --
> 2.26.3
>
Thanks for doing this, will take a look tonight!
- Moritz
prev parent reply other threads:[~2021-06-07 21:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 17:23 [PATCH 0/7] fpga: wrappers for fpga_manager_ops trix
2021-06-07 17:23 ` [PATCH 1/7] fpga: wrap the write_init() op trix
2021-06-07 22:36 ` Moritz Fischer
2021-06-08 6:23 ` Martin Hundebøll
2021-06-08 19:05 ` Tom Rix
2021-06-08 13:55 ` Tom Rix
2021-06-07 17:23 ` [PATCH 2/7] fpga: make write_complete() op optional trix
2021-06-07 17:23 ` [PATCH 3/7] fpga: wrap the write() op trix
2021-06-07 17:23 ` [PATCH 4/7] fpga: wrap the status() op trix
2021-06-07 17:24 ` [PATCH 5/7] fpga: wrap the state() op trix
2021-06-07 17:24 ` [PATCH 6/7] fpga: wrap the fpga_remove() op trix
2021-06-07 17:24 ` [PATCH 7/7] fpga: collect wrappers and change to inline trix
2021-06-07 21:59 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL6WqqUYHkhj+tEj@epycbox.lan \
--to=mdf@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).