From: Luca Ceresoli <luca@lucaceresoli.net>
To: kernel test robot <lkp@intel.com>, linux-fpga@vger.kernel.org
Cc: kbuild-all@lists.01.org, Moritz Fischer <mdf@kernel.org>,
Tom Rix <trix@redhat.com>, Michal Simek <monstr@monstr.eu>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH v3 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()
Date: Sat, 29 Aug 2020 23:08:41 +0200 [thread overview]
Message-ID: <d7478021-33cd-4477-8fa5-3336048d8afe@lucaceresoli.net> (raw)
In-Reply-To: <202008291117.tPETSgId%lkp@intel.com>
Hi,
On 29/08/20 05:30, kernel test robot wrote:
> Hi Luca,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on v5.9-rc2]
> [also build test WARNING on next-20200828]
> [cannot apply to xlnx/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Luca-Ceresoli/fpga-manager-xilinx-spi-remove-stray-comment/20200829-040041
> base: d012a7190fc1fd72ed48911e77ca97ba4521bccd
> compiler: nds32le-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> cppcheck warnings: (new ones prefixed by >>)
>
>>> drivers/fpga/xilinx-spi.c:183:10: warning: Uninitialized variable: expired [uninitvar]
> while (!expired) {
> ^
Oh dear, Please ignore this patch, v4 will be coming with this fixed.
--
Luca
next prev parent reply other threads:[~2020-08-29 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 19:58 [PATCH v3 1/5] fpga manager: xilinx-spi: remove stray comment Luca Ceresoli
2020-08-28 19:58 ` [PATCH v3 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings Luca Ceresoli
2020-08-28 19:58 ` [PATCH v3 3/5] fpga manager: xilinx-spi: fix write_complete timeout handling Luca Ceresoli
2020-08-28 19:58 ` [PATCH v3 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value() Luca Ceresoli
2020-08-29 3:30 ` kernel test robot
2020-08-29 21:08 ` Luca Ceresoli [this message]
2020-08-28 19:58 ` [PATCH v3 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure Luca Ceresoli
2020-08-28 20:17 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7478021-33cd-4477-8fa5-3336048d8afe@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=agust@denx.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mdf@kernel.org \
--cc=monstr@monstr.eu \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).