From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org,
linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v2] xfs_io/encrypt: support passing a keyring key to add_enckey
Date: Thu, 20 Feb 2020 10:42:06 -0800 [thread overview]
Message-ID: <20200220184206.GB9506@magnolia> (raw)
In-Reply-To: <20200218214856.GA147283@gmail.com>
On Tue, Feb 18, 2020 at 01:48:57PM -0800, Eric Biggers wrote:
> On Mon, Feb 03, 2020 at 10:20:13AM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Add a '-k' option to the 'add_enckey' xfs_io command to allow exercising
> > the key_id field that is being added to struct fscrypt_add_key_arg.
> >
> > This is needed for the corresponding test in xfstests.
> >
> > For more details, see the corresponding xfstests patches as well as
> > kernel commit 93edd392cad7 ("fscrypt: support passing a keyring key to
> > FS_IOC_ADD_ENCRYPTION_KEY").
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > No changes since v1.
> >
> > This applies to the for-next branch of xfsprogs.
> >
> > configure.ac | 1 +
> > include/builddefs.in | 4 ++
> > io/encrypt.c | 90 +++++++++++++++++++++++++++++++------------
> > m4/package_libcdev.m4 | 21 ++++++++++
> > man/man8/xfs_io.8 | 10 +++--
> > 5 files changed, 98 insertions(+), 28 deletions(-)
> >
>
> Any comments on this patch? The corresponding xfstests patches were merged.
I didn't see any obvious bugs, though fwiw I'm not that familiar with
fscrypt. This looks like a pretty straightforward addition of a new
field to a kernel call structure and some other plumbing to fill out the
new field with CLI arguments / stdin.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> - Eric
prev parent reply other threads:[~2020-02-20 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 18:20 [PATCH v2] xfs_io/encrypt: support passing a keyring key to add_enckey Eric Biggers
2020-02-18 21:48 ` Eric Biggers
2020-02-20 18:42 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220184206.GB9506@magnolia \
--to=darrick.wong@oracle.com \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).