From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org,
Barani Muthukumaran <bmuthuku@qti.qualcomm.com>,
Kuohong Wang <kuohong.wang@mediatek.com>,
Kim Boojin <boojin.kim@samsung.com>
Subject: Re: [PATCH v8 08/11] fs: introduce SB_INLINECRYPT
Date: Sun, 15 Mar 2020 12:05:32 -0700 [thread overview]
Message-ID: <20200315190532.GF1055@sol.localdomain> (raw)
In-Reply-To: <20200312080253.3667-9-satyat@google.com>
On Thu, Mar 12, 2020 at 01:02:50AM -0700, Satya Tangirala wrote:
> Introduce SB_INLINECRYPT, which is set by filesystems that wish to use
> blk-crypto for file content en/decryption.
>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> ---
> fs/proc_namespace.c | 1 +
> include/linux/fs.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c
> index 273ee82d8aa9..8bf195d3bda6 100644
> --- a/fs/proc_namespace.c
> +++ b/fs/proc_namespace.c
> @@ -49,6 +49,7 @@ static int show_sb_opts(struct seq_file *m, struct super_block *sb)
> { SB_DIRSYNC, ",dirsync" },
> { SB_MANDLOCK, ",mand" },
> { SB_LAZYTIME, ",lazytime" },
> + { SB_INLINECRYPT, ",inlinecrypt" },
> { 0, NULL }
> };
> const struct proc_fs_info *fs_infop;
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3cd4fe6b845e..08a0395674dd 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1370,6 +1370,7 @@ extern int send_sigurg(struct fown_struct *fown);
> #define SB_NODIRATIME 2048 /* Do not update directory access times */
> #define SB_SILENT 32768
> #define SB_POSIXACL (1<<16) /* VFS does not apply the umask */
> +#define SB_INLINECRYPT (1<<17) /* inodes in SB use blk-crypto */
"inodes use blk-crypto" isn't very clear. It could be misunderstand as meaning
something like "does the filesystem contain any encrypted files". I think the
following would be a bit clearer:
/* Use blk-crypto for encrypted files */
(And these flags are obviously per-sb, so there's no need to write "in SB".)
next prev parent reply other threads:[~2020-03-15 19:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 8:02 [PATCH v8 00/11] Inline Encryption Support Satya Tangirala
2020-03-12 8:02 ` [PATCH v8 01/11] block: Keyslot Manager for Inline Encryption Satya Tangirala
2020-03-15 20:08 ` Eric Biggers
2020-03-12 8:02 ` [PATCH v8 02/11] block: Inline encryption support for blk-mq Satya Tangirala
2020-03-19 11:01 ` Christoph Hellwig
2020-03-12 8:02 ` [PATCH v8 03/11] block: Make blk-integrity preclude hardware inline encryption Satya Tangirala
2020-03-15 20:16 ` Eric Biggers
2020-03-19 11:04 ` Christoph Hellwig
2020-03-12 8:02 ` [PATCH v8 04/11] block: blk-crypto-fallback for Inline Encryption Satya Tangirala
2020-03-12 8:02 ` [PATCH v8 05/11] scsi: ufs: UFS driver v2.1 spec crypto additions Satya Tangirala
2020-03-12 8:02 ` [PATCH v8 06/11] scsi: ufs: UFS crypto API Satya Tangirala
2020-03-15 18:24 ` Eric Biggers
2020-03-12 8:02 ` [PATCH v8 07/11] scsi: ufs: Add inline encryption support to UFS Satya Tangirala
2020-03-15 18:38 ` Eric Biggers
2020-03-15 18:48 ` Eric Biggers
2020-03-12 8:02 ` [PATCH v8 08/11] fs: introduce SB_INLINECRYPT Satya Tangirala
2020-03-15 19:05 ` Eric Biggers [this message]
2020-03-12 8:02 ` [PATCH v8 09/11] fscrypt: add inline encryption support Satya Tangirala
2020-03-15 17:20 ` Eric Biggers
2020-03-12 8:02 ` [PATCH v8 10/11] f2fs: " Satya Tangirala
2020-03-15 17:16 ` Eric Biggers
2020-03-12 8:02 ` [PATCH v8 11/11] ext4: " Satya Tangirala
2020-03-12 15:43 ` [PATCH v8 00/11] Inline Encryption Support Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315190532.GF1055@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=bmuthuku@qti.qualcomm.com \
--cc=boojin.kim@samsung.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).