From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Daniel Rosenberg <drosen@google.com>
Subject: Re: [PATCH 4/4] fscrypt: make test_dummy_encryption use v2 by default
Date: Tue, 12 May 2020 20:12:07 -0700 [thread overview]
Message-ID: <20200513031207.GD108075@google.com> (raw)
In-Reply-To: <20200512233251.118314-5-ebiggers@kernel.org>
On 05/12, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Since v1 encryption policies are deprecated, make test_dummy_encryption
> test v2 policies by default.
>
> Note that this causes ext4/023 and ext4/028 to start failing due to
> known bugs in those tests (see previous commit).
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/crypto/policy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c
> index ca0ee337c9627f..cb7fd8f7f0eca1 100644
> --- a/fs/crypto/policy.c
> +++ b/fs/crypto/policy.c
> @@ -632,7 +632,7 @@ int fscrypt_set_test_dummy_encryption(struct super_block *sb,
> const substring_t *arg,
> struct fscrypt_dummy_context *dummy_ctx)
> {
> - const char *argstr = "v1";
> + const char *argstr = "v2";
> const char *argstr_to_free = NULL;
> struct fscrypt_key_specifier key_spec = { 0 };
> int version;
> --
> 2.26.2
next prev parent reply other threads:[~2020-05-13 3:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 23:32 [PATCH 0/4] fscrypt: make '-o test_dummy_encryption' support v2 policies Eric Biggers
2020-05-12 23:32 ` [PATCH 1/4] linux/parser.h: add include guards Eric Biggers
2020-05-13 0:53 ` Theodore Y. Ts'o
2020-05-13 3:06 ` Jaegeuk Kim
2020-05-12 23:32 ` [PATCH 2/4] fscrypt: add fscrypt_add_test_dummy_key() Eric Biggers
2020-05-13 0:55 ` Theodore Y. Ts'o
2020-05-13 3:07 ` Jaegeuk Kim
2020-05-12 23:32 ` [PATCH 3/4] fscrypt: support test_dummy_encryption=v2 Eric Biggers
2020-05-13 3:11 ` Jaegeuk Kim
2020-05-19 2:53 ` Theodore Y. Ts'o
2020-05-19 3:02 ` Eric Biggers
2020-05-19 3:11 ` Eric Biggers
2020-05-19 3:19 ` Jaegeuk Kim
2020-05-19 14:02 ` Theodore Y. Ts'o
2020-05-12 23:32 ` [PATCH 4/4] fscrypt: make test_dummy_encryption use v2 by default Eric Biggers
2020-05-13 3:12 ` Jaegeuk Kim [this message]
2020-05-19 2:55 ` Theodore Y. Ts'o
2020-05-20 22:55 ` [PATCH 0/4] fscrypt: make '-o test_dummy_encryption' support v2 policies Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513031207.GD108075@google.com \
--to=jaegeuk@kernel.org \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).