From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Suleiman Souhlal <suleiman@google.com>,
linux-fscrypt@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [stable] ext4 fscrypt_get_encryption_info() circular locking dependency
Date: Wed, 13 Jan 2021 20:34:12 +0900 [thread overview]
Message-ID: <X/7atDqEyQTb+sGW@google.com> (raw)
In-Reply-To: <X9O0brQ7junfZTfI@sol.localdomain>
Hello,
Eric, sorry for the delay.
On (20/12/11 10:03), Eric Biggers wrote:
> > [..]
> >
> > [ 1598.658233] __rwsem_down_read_failed_common+0x186/0x201
> > [ 1598.658235] call_rwsem_down_read_failed+0x14/0x30
> > [ 1598.658238] down_read+0x2e/0x45
> > [ 1598.658240] rmap_walk_file+0x73/0x1ce
> > [ 1598.658242] page_referenced+0x10d/0x154
> > [ 1598.658247] shrink_active_list+0x1d4/0x475
> > [ 1598.658250] shrink_node+0x27e/0x661
> > [ 1598.658254] try_to_free_pages+0x425/0x7ec
> > [ 1598.658258] __alloc_pages_nodemask+0x80b/0x1514
> > [ 1598.658279] __do_page_cache_readahead+0xd4/0x1a9
> > [ 1598.658282] filemap_fault+0x346/0x573
> > [ 1598.658287] ext4_filemap_fault+0x31/0x44
>
> Could you provide some more information about what is causing these actual
> lockups for you? Are there more stack traces?
I think I have some leads, and, just like you said, this deos not appear
to be ext4 related.
A likely root cause for the lockups I'm observing, is that kswapd
and virtio_balloon have reverse locking order for THP pages:
down_write(mapping->i_mmap_rwsem) --> page->PG_locked
vs
page->PG_locked --> down_read(mapping->i_mmap_rwsem)
-ss
prev parent reply other threads:[~2021-01-13 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 3:36 [stable] ext4 fscrypt_get_encryption_info() circular locking dependency Sergey Senozhatsky
2020-12-11 3:48 ` Eric Biggers
2020-12-11 4:08 ` Sergey Senozhatsky
2020-12-11 4:34 ` Sergey Senozhatsky
2020-12-11 18:03 ` Eric Biggers
2021-01-13 11:34 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/7atDqEyQTb+sGW@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaegeuk@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=suleiman@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).