From: Olga Kornievskaia <kolga@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
<linux-fsdevel@vger.kernel.org>, <hch@lst.de>,
<linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] fs: Don't copy beyond the end of the file
Date: Tue, 7 Mar 2017 18:46:55 -0500 [thread overview]
Message-ID: <0E27E7C0-50AE-4E48-80BF-A9B6738BA4EC@netapp.com> (raw)
In-Reply-To: <20170307234345.GB29977@infradead.org>
> On Mar 7, 2017, at 6:43 PM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Thu, Mar 02, 2017 at 10:40:57AM -0800, Darrick J. Wong wrote:
>> Never mind, I misread vfs_copy as vfs_clone and thought you were talking
>> about something else. :(
>>
>> Sorry about the noise.
>
> And either way we'll need test coverage for copy_file_range before we
> do any more changes to it. I'm sick and tired of this doctoring around
> without having any test coverage. I've asked for it again and again
> and we've made very little progress despite having the code in the tree
> for almost a year and a half.
Anna has added test cases to the xfstest suite. Is there something that’s missing?
next prev parent reply other threads:[~2017-03-07 23:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:02 [PATCH v1 0/3] VFS changes for NFSv4.2 "inter" server-to-server COPY op Olga Kornievskaia
2017-03-02 16:02 ` [PATCH v1 1/3] fs: Don't copy beyond the end of the file Olga Kornievskaia
2017-03-02 16:58 ` Darrick J. Wong
2017-03-02 18:21 ` Olga Kornievskaia
2017-03-02 18:40 ` Darrick J. Wong
2017-03-07 23:43 ` Christoph Hellwig
2017-03-07 23:46 ` Olga Kornievskaia [this message]
2017-03-07 23:50 ` Christoph Hellwig
2017-03-08 15:39 ` Olga Kornievskaia
2017-03-08 15:57 ` Christoph Hellwig
2017-03-02 16:02 ` [PATCH v1 2/3] VFS permit cross device vfs_copy_file_range Olga Kornievskaia
2017-03-02 16:07 ` Christoph Hellwig
2017-03-02 16:38 ` Olga Kornievskaia
2017-03-07 20:35 ` Olga Kornievskaia
2017-03-15 18:09 ` J. Bruce Fields
2017-03-21 15:50 ` J. Bruce Fields
[not found] ` <56CDE406-AE24-40E4-852C-1C47C5CCD37E@netapp.com>
2017-03-21 19:03 ` J. Bruce Fields
2017-03-22 17:16 ` Olga Kornievskaia
2018-08-31 16:13 ` Florian Weimer
2018-08-31 16:25 ` Olga Kornievskaia
2018-08-31 22:56 ` Steve French
2017-03-02 16:02 ` [PATCH v1 3/3] VFS don't try clone if superblocks are different Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E27E7C0-50AE-4E48-80BF-A9B6738BA4EC@netapp.com \
--to=kolga@netapp.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).