From: David Howells <dhowells@redhat.com>
To: Alan Jenkins <alan.christopher.jenkins@gmail.com>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
torvalds@linux-foundation.org, ebiederm@xmission.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
mszeredi@redhat.com
Subject: Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12]
Date: Fri, 19 Oct 2018 22:35:09 +0100 [thread overview]
Message-ID: <10117.1539984909@warthog.procyon.org.uk> (raw)
In-Reply-To: <97872123-70be-2833-ea7a-a463ce204b53@gmail.com>
Alan Jenkins <alan.christopher.jenkins@gmail.com> wrote:
> And the first sequence I mentioned - close the FD, then mount+unmount -
> seems to be unchanged.
Unchanged in what sense? Still breaks? I thought I'd fixed that - or are we
talking about a different first sequence?
Sorry, I'm losing track of how many different ways of breaking open_tree() and
move_mount() you've posted. I don't suppose you could post a checklist?
> I guess this tries to fix the second of the two sequences I mentioned -
> mount+unmount, then close the FD. It doesn't seem to work.
>
> # open_tree_clone 3</mnt 3 sh
> # cd /proc/self/fd/3
> # mount --move . /mnt
> [ 41.747831] mnt_flags=1020 umount=0
> # cd /
> # umount /mnt
> umount: /mnt: target is busy
>
> ^ a newly introduced bug? I do not remember having this problem before.
>
> # umount -l /mnt
Sigh, so I see. I have the attached trace from this sequence.
David
----
Command "open_tree_clone 3</mnt 3 sh"
sh-3614 M=421a9872 u=1 ALC sp=clone_mnt+0x31/0x30a
sh-3614 M=421a9872 u=2 GET sp=do_dentry_open+0x24/0x2d3
sh-3614 M=421a9872 u=1 PUT sp=__se_sys_open_tree+0x195/0x1da
sh-3614 M=421a9872 u=2 GET sp=proc_fd_link+0x106/0x124
sh-3614 M=421a9872 u=1 PUT sp=vfs_statx+0x95/0xcc
Command "cd /proc/self/fd/3":
sh-3614 M=421a9872 u=2 GET sp=proc_fd_link+0x106/0x124
sh-3614 M=421a9872 u=3 GET sp=set_fs_pwd+0x37/0xdb
sh-3614 M=421a9872 u=2 PUT sp=ksys_chdir+0x88/0xbd
sh-3614 M=421a9872 u=3 GET sp=legitimize_path.isra.7+0x16/0x50
sh-3614 M=421a9872 u=2 PUT sp=vfs_statx+0x95/0xcc
Command "mount --move . /mnt":
sh-3614 M=421a9872 u=3 GET sp=copy_fs_struct+0xcc/0xde
mount-3615 M=421a9872 u=4 GET sp=legitimize_path.isra.7+0x16/0x50
mount-3615 M=421a9872 u=3 PUT sp=vfs_statx+0x95/0xcc
mount-3615 M=421a9872 u=4 GET sp=legitimize_path.isra.7+0x16/0x50
mount-3615 M=421a9872 u=5 GET sp=do_dentry_open+0x24/0x2d3
mount-3615 M=421a9872 u=4 PUT sp=terminate_walk+0x20/0xda
mount-3615 M=421a9872 u=5 GET sp=legitimize_path.isra.7+0x16/0x50
mount-3615 M=421a9872 u=4 PUT sp=vfs_statx+0x95/0xcc
mount-3615 M=421a9872 u=3 PUT sp=__fput+0x180/0x1c1
mount-3615 M=421a9872 u=4 GET sp=legitimize_path.isra.7+0x16/0x50
mount-3615 M=421a9872 u=4 0x4e sp= (null)
mount-3615 M=421a9872 u=5 GET sp=do_move_mount+0x216/0x298
mount-3615 M=421a9872 u=4 PUT sp=do_mount+0x715/0x929
mount-3615 M=421a9872 u=3 PUT sp=free_fs_struct+0x1e/0x2e
Command "cd /":
sh-3614 M=421a9872 u=2 PUT sp=set_fs_pwd+0xb8/0xdb
Command "umount /mnt":
umount-3616 M=421a9872 u=3 GET sp=legitimize_path.isra.7+0x16/0x50
umount-3616 M=421a9872 u=2 PUT sp=vfs_statx+0x95/0xcc
umount-3616 M=421a9872 u=3 GET sp=legitimize_path.isra.7+0x16/0x50
umount-3616 M=421a9872 u=2 PUT sp=vfs_statx+0x95/0xcc
umount-3616 M=421a9872 u=3 GET sp=legitimize_path.isra.7+0x16/0x50
umount-3616 M=421a9872 u=2 PUT sp=user_statfs+0x61/0x98
umount-3616 M=421a9872 u=3 GET sp=legitimize_mnt+0x12/0x108
umount-3616 M=421a9872 u=2 PUT sp=ksys_umount+0x3e8/0x40e
(Fails, -EBUSY).
Command "umount -l /mnt":
umount-3617 M=421a9872 u=3 GET sp=legitimize_mnt+0x12/0x108
umount-3617 M=421a9872 u=2 PUT sp=pin_kill+0x11c/0x325
umount-3617 M=421a9872 u=1 PUT sp=ksys_umount+0x3e8/0x40e
Command "exec 3<&-":
(Goes weird: bash still responds, but trying to run a command locks up that
shell; can still log in with ssh, but can't then run commands).
David
next prev parent reply other threads:[~2018-10-20 5:43 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 16:30 [PATCH 00/34] VFS: Introduce filesystem context [ver #12] David Howells
2018-09-21 16:30 ` [PATCH 01/34] vfs: syscall: Add open_tree(2) to reference or clone a mount " David Howells
2018-10-21 16:41 ` Eric W. Biederman
2018-09-21 16:30 ` [PATCH 02/34] vfs: syscall: Add move_mount(2) to move mounts around " David Howells
2018-09-21 16:30 ` [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE " David Howells
2018-10-05 18:24 ` Alan Jenkins
2018-10-07 10:48 ` Alan Jenkins
2018-10-07 19:20 ` Alan Jenkins
2018-10-10 12:36 ` David Howells
2018-10-12 14:22 ` Alan Jenkins
2018-10-12 14:54 ` David Howells
2018-10-12 14:57 ` Alan Jenkins
2018-10-11 9:17 ` David Howells
2018-10-11 11:48 ` Alan Jenkins
2018-10-11 13:10 ` David Howells
2018-10-11 12:14 ` David Howells
2018-10-11 12:23 ` Alan Jenkins
2018-10-11 15:33 ` David Howells
2018-10-11 18:38 ` Eric W. Biederman
2018-10-11 20:17 ` David Howells
2018-10-13 6:06 ` Al Viro
2018-10-17 17:45 ` Alan Jenkins
2018-10-18 20:09 ` David Howells
2018-10-18 20:58 ` David Howells
2018-10-19 11:57 ` David Howells
2018-10-19 13:37 ` David Howells
2018-10-19 17:35 ` Alan Jenkins
2018-10-19 21:35 ` David Howells [this message]
2018-10-19 21:40 ` David Howells
2018-10-19 22:36 ` David Howells
2018-10-20 5:25 ` Al Viro
2018-10-20 11:06 ` Alan Jenkins
2018-10-20 11:48 ` Al Viro
2018-10-20 12:26 ` Al Viro
2018-10-21 0:40 ` David Howells
2018-10-10 11:56 ` David Howells
2018-10-10 12:31 ` David Howells
2018-10-10 12:39 ` Alan Jenkins
2018-10-10 12:50 ` David Howells
2018-10-10 13:02 ` David Howells
2018-10-10 13:06 ` Alan Jenkins
2018-10-21 16:57 ` Eric W. Biederman
2018-10-23 11:19 ` Alan Jenkins
2018-10-23 16:22 ` Al Viro
2018-09-21 16:30 ` [PATCH 04/34] vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled " David Howells
2018-09-21 16:30 ` [PATCH 05/34] vfs: Introduce the basic header for the new mount API's filesystem context " David Howells
2018-09-21 16:30 ` [PATCH 06/34] vfs: Introduce logging functions " David Howells
2018-09-21 16:31 ` [PATCH 07/34] vfs: Add configuration parser helpers " David Howells
2019-03-14 7:46 ` Geert Uytterhoeven
2019-03-14 10:27 ` David Howells
2019-03-14 10:49 ` Geert Uytterhoeven
2018-09-21 16:31 ` [PATCH 08/34] vfs: Add LSM hooks for the new mount API " David Howells
2018-09-21 16:31 ` [PATCH 09/34] vfs: Put security flags into the fs_context struct " David Howells
2018-09-21 16:31 ` [PATCH 10/34] selinux: Implement the new mount API LSM hooks " David Howells
2018-09-21 16:31 ` [PATCH 11/34] smack: Implement filesystem context security " David Howells
2018-09-21 16:31 ` [PATCH 12/34] apparmor: Implement security hooks for the new mount API " David Howells
2018-09-21 16:31 ` [PATCH 13/34] tomoyo: " David Howells
2018-09-21 16:32 ` [PATCH 14/34] vfs: Separate changing mount flags full remount " David Howells
2018-09-21 16:32 ` [PATCH 15/34] vfs: Implement a filesystem superblock creation/configuration context " David Howells
2018-09-21 16:32 ` [PATCH 16/34] vfs: Remove unused code after filesystem context changes " David Howells
2018-09-21 16:32 ` [PATCH 17/34] procfs: Move proc_fill_super() to fs/proc/root.c " David Howells
2018-09-21 16:32 ` [PATCH 18/34] proc: Add fs_context support to procfs " David Howells
2018-09-21 16:32 ` [PATCH 19/34] ipc: Convert mqueue fs to fs_context " David Howells
2018-09-21 16:32 ` [PATCH 20/34] cpuset: Use " David Howells
2018-09-21 16:33 ` [PATCH 21/34] kernfs, sysfs, cgroup, intel_rdt: Support " David Howells
2018-11-19 4:23 ` Andrei Vagin
2018-12-06 17:08 ` Andrei Vagin
2018-09-21 16:33 ` [PATCH 22/34] hugetlbfs: Convert to " David Howells
2018-09-21 16:33 ` [PATCH 23/34] vfs: Remove kern_mount_data() " David Howells
2018-09-21 16:33 ` [PATCH 24/34] vfs: Provide documentation for new mount API " David Howells
2018-09-21 16:33 ` [PATCH 25/34] Make anon_inodes unconditional " David Howells
2018-09-21 16:33 ` [PATCH 26/34] vfs: syscall: Add fsopen() to prepare for superblock creation " David Howells
2018-09-21 16:33 ` [PATCH 27/34] vfs: Implement logging through fs_context " David Howells
2018-09-21 16:33 ` [PATCH 28/34] vfs: Add some logging to the core users of the fs_context log " David Howells
2018-09-21 16:34 ` [PATCH 29/34] vfs: syscall: Add fsconfig() for configuring and managing a context " David Howells
2018-09-21 16:34 ` [PATCH 30/34] vfs: syscall: Add fsmount() to create a mount for a superblock " David Howells
2018-09-21 16:34 ` [PATCH 31/34] vfs: syscall: Add fspick() to select a superblock for reconfiguration " David Howells
2018-10-12 14:49 ` Alan Jenkins
2018-10-13 6:11 ` Al Viro
2018-10-13 9:45 ` Alan Jenkins
2018-10-13 23:04 ` Andy Lutomirski
2018-10-17 13:15 ` David Howells
2018-10-17 13:20 ` David Howells
2018-10-17 14:31 ` Alan Jenkins
2018-10-17 14:35 ` Eric W. Biederman
2018-10-17 14:55 ` Alan Jenkins
2018-10-17 15:24 ` David Howells
2018-10-17 15:38 ` Eric W. Biederman
2018-10-17 15:45 ` David Howells
2018-10-17 17:41 ` Alan Jenkins
2018-10-17 21:20 ` David Howells
2018-10-17 22:13 ` Alan Jenkins
2018-09-21 16:34 ` [PATCH 32/34] afs: Add fs_context support " David Howells
2018-09-21 16:34 ` [PATCH 33/34] afs: Use fs_context to pass parameters over automount " David Howells
2018-09-21 16:34 ` [PATCH 34/34] vfs: Add a sample program for the new mount API " David Howells
2018-12-17 14:12 ` Anders Roxell
2018-12-20 16:36 ` David Howells
2018-10-04 18:37 ` [PATCH 00/34] VFS: Introduce filesystem context " Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10117.1539984909@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=alan.christopher.jenkins@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).