From: Miklos Szeredi <mszeredi@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
Subject: Re: [git pull] vfs pile 1
Date: Wed, 11 Jan 2012 14:12:36 +0100 [thread overview]
Message-ID: <1326287556.13736.12.camel@tucsk.pomaz.szeredi.hu> (raw)
In-Reply-To: <20120111124001.GA834@infradead.org>
On Wed, 2012-01-11 at 07:40 -0500, Christoph Hellwig wrote:
> On Wed, Jan 11, 2012 at 01:36:22PM +0100, Miklos Szeredi wrote:
> > There are a couple of options:
> >
> > a) leave it as it is
> >
> > b) change that set_nlink() in xfs into a
> >
> > if (nlink)
> > set_nlink(nlink);
> > else
> > clear_nlink();
> >
> > c) remove the printk from set_nlink(). This effectively makes
> > set_nlink(0) an alias of clear_nlink().
> >
> > IIRC your preference is c. What do others think?
>
> Yes. a) really isn't an option - we don't want to spew thousands of
> useless messages during a log recovery for an operation that's totally
> normal. b) is okay, too - but it's not just xfs that needs to be
> covered, but any fs that support the concept of recovering from open
> but unlinked inodes after a crash. It's just that no one else seems
> to have regular QA for that code path.
Since it's a ratelimited printk there won't be thousands of messages. I
think this is just a cosmetic issue and lack of QA isn't a problem. If
the messages are bothersome it can be fixed.
Thanks,
Miklos
next prev parent reply other threads:[~2012-01-11 13:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 2:23 [git pull] vfs pile 1 Al Viro
2012-01-08 23:04 ` Linus Torvalds
2012-01-08 23:50 ` Al Viro
2012-01-08 23:53 ` Al Viro
2012-01-09 0:11 ` Linus Torvalds
2012-01-09 0:25 ` Al Viro
2012-01-09 0:39 ` Linus Torvalds
2012-01-09 2:12 ` Al Viro
2012-01-09 15:11 ` Ted Ts'o
2012-01-11 11:58 ` Christoph Hellwig
2012-01-11 12:36 ` Miklos Szeredi
2012-01-11 12:40 ` Christoph Hellwig
2012-01-11 13:12 ` Miklos Szeredi [this message]
2012-01-11 15:23 ` Ted Ts'o
2012-01-11 16:19 ` Al Viro
2012-01-12 11:41 ` Miklos Szeredi
-- strict thread matches above, loose matches on Subject: below --
2018-06-04 0:59 [git pull] vfs, " Al Viro
2016-12-16 13:30 [git pull] vfs " Al Viro
2015-09-06 2:55 Al Viro
2015-06-22 6:47 Al Viro
2014-01-27 14:25 Al Viro
2014-01-27 23:05 ` Stephen Rothwell
2014-01-29 3:26 ` Linus Torvalds
2014-01-29 13:37 ` Jan Kara
2014-01-30 2:02 ` Kim Jaegeuk
2014-01-30 15:26 ` Jan Kara
2014-01-30 13:07 ` Christoph Hellwig
2013-02-27 3:24 Al Viro
2012-03-21 3:31 Al Viro
2011-05-26 11:53 Al Viro
2011-01-13 5:35 Al Viro
2011-01-13 6:25 ` Stephen Rothwell
2011-01-13 8:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326287556.13736.12.camel@tucsk.pomaz.szeredi.hu \
--to=mszeredi@suse.cz \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=toshi.okajima@jp.fujitsu.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).