From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:35952 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbcHAGdx (ORCPT ); Mon, 1 Aug 2016 02:33:53 -0400 Date: Sun, 31 Jul 2016 23:33:22 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, bfoster@redhat.com, xfs@oss.sgi.com Subject: Re: [PATCH 01/47] vfs: fix return type of ioctl_file_dedupe_range Message-ID: <20160801063322.GC15590@infradead.org> References: <146907695530.25461.3225785294902719773.stgit@birch.djwong.org> <146907696757.25461.13451944377009612990.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146907696757.25461.13451944377009612990.stgit@birch.djwong.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jul 20, 2016 at 09:56:07PM -0700, Darrick J. Wong wrote: > All the VFS functions in the dedupe ioctl path return int status, so > the ioctl handler ought to as well. > > Found by Coverity, CID 1350952. > > Signed-off-by: Darrick J. Wong Nothing to do with rmap, or XFS for that matter. Please send it directly to Al. Otherwise: Reviewed-by: Christoph Hellwig