From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-pf0-f194.google.com ([209.85.192.194]:40503 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750878AbeC0Efu (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 27 Mar 2018 00:35:50 -0400
Received: by mail-pf0-f194.google.com with SMTP id v66so5951436pfv.7
        for <linux-fsdevel@vger.kernel.org>; Mon, 26 Mar 2018 21:35:50 -0700 (PDT)
Date: Mon, 26 Mar 2018 21:35:47 -0700
From: Omar Sandoval <osandov@osandov.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@fb.com>,
        kernel-team@fb.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] loop: use interruptible lock in ioctls
Message-ID: <20180327043547.GA14473@vader>
References: <cover.1522106130.git.osandov@fb.com>
 <7ec1489d2ca54e886713efe5beb6dd379c2279b6.1522106130.git.osandov@fb.com>
 <20180327000421.GC10054@bombadil.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180327000421.GC10054@bombadil.infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Mar 26, 2018 at 05:04:21PM -0700, Matthew Wilcox wrote:
> On Mon, Mar 26, 2018 at 04:16:26PM -0700, Omar Sandoval wrote:
> > Even after the previous patch to drop lo_ctl_mutex while calling
> > vfs_getattr(), there are other cases where we can end up sleeping for a
> > long time while holding lo_ctl_mutex. Let's avoid the uninterruptible
> > sleep from the ioctls.
> 
> Umm ... you want these ioctls to return -EINTR just because you resized
> an xterm?  I think you really meant mutex_lock_killable().
> 

Thanks, yeah, will fix.