From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:58326 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753544AbeC2SPR (ORCPT ); Thu, 29 Mar 2018 14:15:17 -0400 Date: Thu, 29 Mar 2018 18:15:15 +0000 From: "Luis R. Rodriguez" To: Waiman Long Cc: "Luis R. Rodriguez" , Kees Cook , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet , Andrew Morton , Al Viro , Matthew Wilcox , "Eric W. Biederman" Subject: Re: [PATCH v5 1/9] sysctl: Add flags to support min/max range clamping Message-ID: <20180329181515.GL30543@wotan.suse.de> References: <1521224030-2185-1-git-send-email-longman@redhat.com> <1521224030-2185-2-git-send-email-longman@redhat.com> <20180317011021.GB4449@wotan.suse.de> <35f54e8f-b80e-aa3b-b008-79ba7ca3bff2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35f54e8f-b80e-aa3b-b008-79ba7ca3bff2@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Mar 19, 2018 at 11:39:19AM -0400, Waiman Long wrote: > On 03/16/2018 09:10 PM, Luis R. Rodriguez wrote: > > On Fri, Mar 16, 2018 at 02:13:42PM -0400, Waiman Long wrote: > >> When the CTL_FLAGS_CLAMP_RANGE flag is set in the ctl_table > >> entry, any update from the userspace will be clamped to the given > >> range without error if either the proc_dointvec_minmax() or the > >> proc_douintvec_minmax() handlers is used. > > I don't get it. Why define a generic range flag when we can be mores specific and > > you do that in your next patch. What's the point of this flag then? > > > > Luis > > I was thinking about using the signed/unsigned bits as just annotations > for ranges for future extension. For the purpose of this patchset alone, > I can merge the three bits into just two. Only introduce flags which you will actually use in the same patch series. Luis