From: Andrew Lunn <andrew@lunn.ch>
To: Alex Vesker <valex@mellanox.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, viro@zeniv.linux.org.uk,
ebiederm@xmission.com, stephen@networkplumber.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
ganeshgr@chelsio.com, nirranjan@chelsio.com,
indranil@chelsio.com
Subject: Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel
Date: Tue, 3 Apr 2018 14:35:56 +0200 [thread overview]
Message-ID: <20180403123556.GA31740@lunn.ch> (raw)
In-Reply-To: <0d106ece-4669-389d-da30-63a630ca625c@mellanox.com>
On Tue, Apr 03, 2018 at 08:43:27AM +0300, Alex Vesker wrote:
>
>
> On 4/2/2018 12:12 PM, Jiri Pirko wrote:
> >Fri, Mar 30, 2018 at 05:11:29PM CEST, andrew@lunn.ch wrote:
> >>>Please see:
> >>>http://patchwork.ozlabs.org/project/netdev/list/?series=36524
> >>>
> >>>I bevieve that the solution in the patchset could be used for
> >>>your usecase too.
> >>Hi Jiri
> >>
> >>https://lkml.org/lkml/2018/3/20/436
> >>
> >>How well does this API work for a 2Gbyte snapshot?
> >Ccing Alex who did the tests.
>
> I didn't check the performance for such a large snapshot.
> From my measurement it takes 0.09s for 1 MB of data this means
> about ~3m.
I was not really thinking about performance. More about how well does
the system work when you ask the kernel for 2GB of RAM to put a
snapshot into? And given your current design, you need another 2GB
buffer for the driver to use before calling this new API.
So i'm asking, how well does this API scale?
I think you need to remove the need for a second buffer in the
driver. Either the driver allocates the buffer and hands it over, or
your core code allocates the buffer and gives it to the driver to
fill. Maybe look at what makes most sense for the crash dump code?
Andrew
next prev parent reply other threads:[~2018-04-03 12:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 10:56 [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel Rahul Lakkireddy
2018-03-24 10:56 ` [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel Rahul Lakkireddy
2018-03-25 12:43 ` kbuild test robot
2018-03-30 10:39 ` Jiri Pirko
2018-03-30 10:51 ` Rahul Lakkireddy
2018-03-30 18:42 ` Eric W. Biederman
2018-04-02 9:11 ` Jiri Pirko
2018-04-02 12:21 ` Andrew Lunn
2018-04-02 12:30 ` Rahul Lakkireddy
2018-04-03 7:04 ` Jiri Pirko
2018-03-30 15:11 ` Andrew Lunn
2018-04-02 9:12 ` Jiri Pirko
2018-04-03 5:43 ` Alex Vesker
2018-04-03 12:35 ` Andrew Lunn [this message]
2018-03-24 10:56 ` [PATCH net-next v2 2/2] cxgb4: " Rahul Lakkireddy
2018-03-24 15:18 ` Andrew Lunn
2018-03-24 22:18 ` Thadeu Lima de Souza Cascardo
2018-03-25 0:17 ` Eric W. Biederman
2018-03-24 15:20 ` [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel Eric W. Biederman
2018-03-26 13:45 ` Rahul Lakkireddy
2018-03-27 13:17 ` Eric W. Biederman
2018-03-27 15:27 ` Rahul Lakkireddy
2018-03-27 15:59 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403123556.GA31740@lunn.ch \
--to=andrew@lunn.ch \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=ganeshgr@chelsio.com \
--cc=indranil@chelsio.com \
--cc=jiri@resnulli.us \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=stephen@networkplumber.org \
--cc=torvalds@linux-foundation.org \
--cc=valex@mellanox.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).