From: Seth Forshee <seth.forshee@canonical.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Alban Crequy <alban@kinvolk.io>,
Sargun Dhillon <sargun@sargun.me>,
Dongsu Park <dongsu@kinvolk.io>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] fuse: Ensure posix acls are translated outside of init_user_ns
Date: Tue, 8 May 2018 08:37:50 -0500 [thread overview]
Message-ID: <20180508133750.GA29084@ubuntu-xps13> (raw)
In-Reply-To: <87r2mre5b3.fsf@xmission.com>
On Fri, May 04, 2018 at 11:47:28AM -0500, Eric W. Biederman wrote:
>
> Ensure the translation happens by failing to read or write
> posix acls when the filesystem has not indicated it supports
> posix acls.
>
> This ensures that modern cached posix acl support is available
> and used when dealing with posix acls. This is important
> because only that path has the code to convernt the uids and
> gids in posix acls into the user namespace of a fuse filesystem.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> ---
>
> Miklos after several attempts to handle this better last cycle. I
> figure we should go with the stupid version for now. I think I know
> how to do better but I don't want that to gate forward progress on
> fully unprivileged fuse mounts. Especially as this is the last known
> issue to deal with.
This seems reasonable as a short-term measure.
Acked-by: Seth Forshee <seth.forshee@canonical.com>
next prev parent reply other threads:[~2018-05-08 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 16:47 [PATCH] fuse: Ensure posix acls are translated outside of init_user_ns Eric W. Biederman
2018-05-08 13:37 ` Seth Forshee [this message]
2018-05-23 16:11 ` Eric W. Biederman
2018-05-29 12:42 ` Eric W. Biederman
2018-05-29 12:55 ` Miklos Szeredi
2018-05-29 14:02 ` Eric W. Biederman
2018-05-29 14:04 ` [PATCH] fuse: Allow fully unprivileged mounts Eric W. Biederman
2018-05-31 14:45 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508133750.GA29084@ubuntu-xps13 \
--to=seth.forshee@canonical.com \
--cc=alban@kinvolk.io \
--cc=containers@lists.linux-foundation.org \
--cc=dongsu@kinvolk.io \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=sargun@sargun.me \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).