From: David Sterba <dsterba@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 0/3] Btrfs: stop abusing current->journal_info for direct I/O
Date: Fri, 11 May 2018 11:26:06 +0200 [thread overview]
Message-ID: <20180511092606.GN6649@twin.jikos.cz> (raw)
In-Reply-To: <cover.1525933432.git.osandov@fb.com>
On Thu, May 10, 2018 at 11:30:09PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Hi, everyone,
>
> Btrfs currently abuses current->journal_info in btrfs_direct_IO() in
> order to pass around some state to get_block() and submit_io(). This
> hack is ugly and unnecessary because the data we pass around is only
> used in one call frame.
I'd very much like to get rid of the journal_info hack. The changes to
ther filesystems are minimal.
The 3 patches look good to me, you can add my reviewed-by for btrfs
and ack for the rest. I'm going to do a fstests round too.
next prev parent reply other threads:[~2018-05-11 9:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 6:30 [PATCH 0/3] Btrfs: stop abusing current->journal_info for direct I/O Omar Sandoval
2018-05-11 6:30 ` [PATCH 1/3] fs: add initial bh_result->b_private value to __blockdev_direct_IO() Omar Sandoval
2018-05-11 20:05 ` Al Viro
2018-05-11 20:30 ` Omar Sandoval
2018-05-11 20:32 ` Al Viro
2018-05-11 20:41 ` Omar Sandoval
2018-05-14 16:35 ` David Sterba
2018-06-25 17:16 ` David Sterba
2018-06-29 7:02 ` Omar Sandoval
2018-05-11 6:30 ` [PATCH 2/3] fs: add private argument to dio_submit_t Omar Sandoval
2018-05-11 6:30 ` [PATCH 3/3] Btrfs: stop abusing current->journal_info in btrfs_direct_IO() Omar Sandoval
2018-05-11 9:26 ` David Sterba [this message]
2018-05-11 9:53 ` [PATCH 0/3] Btrfs: stop abusing current->journal_info for direct I/O Nikolay Borisov
2018-05-11 10:24 ` David Sterba
2018-05-11 17:28 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511092606.GN6649@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).