From: Mark Fasheh <mfasheh@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org,
Mark Fasheh <mfasheh@suse.de>
Subject: [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted
Date: Fri, 11 May 2018 12:26:51 -0700 [thread overview]
Message-ID: <20180511192651.21324-3-mfasheh@suse.de> (raw)
In-Reply-To: <20180511192651.21324-1-mfasheh@suse.de>
Right now we return EINVAL if a process does not have permission to dedupe a
file. This was an oversight on my part. EPERM gives a true description of
the nature of our error, and EINVAL is already used for the case that the
filesystem does not support dedupe.
Signed-off-by: Mark Fasheh <mfasheh@suse.de>
---
fs/read_write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index 77986a2e2a3b..8edef43a182c 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -2038,7 +2038,7 @@ int vfs_dedupe_file_range(struct file *file, struct file_dedupe_range *same)
info->status = -EINVAL;
} else if (!(is_admin || (dst_file->f_mode & FMODE_WRITE) ||
uid_eq(current_fsuid(), dst->i_uid))) {
- info->status = -EINVAL;
+ info->status = -EPERM;
} else if (file->f_path.mnt != dst_file->f_path.mnt) {
info->status = -EXDEV;
} else if (S_ISDIR(dst->i_mode)) {
--
2.15.1
next prev parent reply other threads:[~2018-05-11 19:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 19:26 [PATCH 0/2] vfs: better dedupe permission check Mark Fasheh
2018-05-11 19:26 ` [PATCH 1/2] vfs: allow dedupe of user owned read-only files Mark Fasheh
2018-05-11 23:58 ` Darrick J. Wong
2018-05-12 2:49 ` Adam Borowski
2018-05-13 18:16 ` Mark Fasheh
2018-05-13 20:50 ` Adam Borowski
2018-05-17 23:01 ` Mark Fasheh
2018-05-11 19:26 ` Mark Fasheh [this message]
2018-05-12 0:06 ` [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted Darrick J. Wong
2018-05-12 4:15 ` Amir Goldstein
2018-05-12 4:37 ` Duncan
2018-05-13 14:30 ` Adam Borowski
2018-05-13 18:21 ` Mark Fasheh
2018-05-13 18:26 ` Darrick J. Wong
2018-05-17 5:15 ` Zygo Blaxell
2018-05-17 23:03 ` Mark Fasheh
2018-05-14 14:58 ` David Sterba
2018-09-10 23:21 [PATCH v6 0/2] vfs: fix dedupe permission check Mark Fasheh
2018-09-10 23:21 ` [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511192651.21324-3-mfasheh@suse.de \
--to=mfasheh@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).