From: Christoph Hellwig <hch@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] fs: iomap: Change return type to vm_fault_t
Date: Tue, 15 May 2018 00:10:25 -0700 [thread overview]
Message-ID: <20180515071025.GB8522@infradead.org> (raw)
In-Reply-To: <CAFqt6zYor2ZRPVsPbto4NNhy04suwmytZdcjjY7kstFHcdXPZg@mail.gmail.com>
On Mon, May 14, 2018 at 11:45:19PM +0530, Souptick Joarder wrote:
> Any further comment on this patch ? We would like to get this patch
> in queue for 4.18.
NAK. This is coplete churn. As said before a proper type for VM faults
might be useful, but random patches that change bits around aren't.
Please send out the whole picture instead of artifially inflating your
commit count while making everyone elses life harder.
next prev parent reply other threads:[~2018-05-15 7:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 20:02 [PATCH] fs: iomap: Change return type to vm_fault_t Souptick Joarder
2018-05-14 18:15 ` Souptick Joarder
2018-05-15 7:10 ` Christoph Hellwig [this message]
2018-05-15 8:00 ` Souptick Joarder
2018-07-02 15:43 Souptick Joarder
2018-07-02 17:52 ` Andreas Gruenbacher
2018-07-03 21:39 ` Darrick J. Wong
2018-07-03 21:52 ` Andreas Gruenbacher
2018-07-20 5:01 ` Souptick Joarder
2018-07-20 6:09 ` Darrick J. Wong
2018-07-20 6:55 ` Souptick Joarder
2018-07-20 19:36 ` Matthew Wilcox
2018-08-27 17:20 Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515071025.GB8522@infradead.org \
--to=hch@infradead.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).