From: Christoph Hellwig <hch@infradead.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Aleksei Besogonov <cyberax@amazon.com>,
kernel-team@fb.com
Subject: Re: [PATCH v2 1/2] iomap: provide more useful errors for invalid swap files
Date: Wed, 16 May 2018 10:46:45 -0700 [thread overview]
Message-ID: <20180516174645.GA8815@infradead.org> (raw)
In-Reply-To: <20180516173251.GA29231@vader>
On Wed, May 16, 2018 at 10:32:51AM -0700, Omar Sandoval wrote:
> On Wed, May 16, 2018 at 10:25:31AM -0700, Christoph Hellwig wrote:
> > On Wed, May 16, 2018 at 09:45:50AM -0700, Omar Sandoval wrote:
> > > + if ((iomap->type != IOMAP_MAPPED && iomap->type != IOMAP_UNWRITTEN) ||
> > > + iomap->addr == IOMAP_NULL_ADDR) {
> > > + pr_err("swapon: file has unallocated extents\n");
> > > + return -EINVAL;
> > > + }
> >
> > The two are really different cases - IOMAP_NULL_ADDR shouldn't really
> > happen for any of the above. Although we might have to move the
> > inline check before the type check above for the message to make sense.
> >
> > I have a patch in the local queue that makes inline a type instead of
> > a flag, btw as it really isn't a flag.
>
> So something like this, moving the inline check and removing the hole
> check since that doesn't make sense for mapped or unwritten? Then the
> inline flag check can be converted to a type check.
Yes, this looks great!
next prev parent reply other threads:[~2018-05-16 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 16:45 [PATCH v2 0/2] iomap: swapfile tweaks Omar Sandoval
2018-05-16 16:45 ` [PATCH v2 1/2] iomap: provide more useful errors for invalid swap files Omar Sandoval
2018-05-16 16:54 ` Darrick J. Wong
2018-05-16 17:25 ` Christoph Hellwig
2018-05-16 17:32 ` Omar Sandoval
2018-05-16 17:46 ` Christoph Hellwig [this message]
2018-05-16 18:11 ` Darrick J. Wong
2018-05-16 18:22 ` Christoph Hellwig
2018-05-16 16:45 ` [PATCH v2 2/2] iomap: don't allow holes in swapfiles Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516174645.GA8815@infradead.org \
--to=hch@infradead.org \
--cc=cyberax@amazon.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).