From: Matthew Wilcox <willy@infradead.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: commit b4678df184b causing xfstests regressions
Date: Fri, 18 May 2018 19:17:58 -0700 [thread overview]
Message-ID: <20180519021758.GA28858@bombadil.infradead.org> (raw)
In-Reply-To: <20180518225037.GA26206@thunk.org>
On Fri, May 18, 2018 at 06:50:37PM -0400, Theodore Y. Ts'o wrote:
> Hi Matthew,
>
> Commit b4678df184b: "errseq: Always report a writeback error once"
> appears to be causing xfstests regressions. For ext4, running
> "gce-xfstests -c 4k -g auto" will result in reliable shared/298
> failures which go away if I revert b4678df184b.
Thanks; I'll take a look. Monday is a holiday in Canada, so it may be
Tuesday before I get to it.
> Darrick has also reported occasional generic/047 failures, which I
> have seen at least once as well. I believe two are linked, because
> after instrumenting mke2fs in shared/298, the failure is happening
> after creating a new 300 MB file:
>
> dd if=/dev/zero of=$img_file bs=1M count=300 &> /dev/null
>
> creating a new loop device
>
> loop_dev=$(_create_loop_device $img_file)
>
> ... and then run mke2fs on that loop device.
>
> The instrumentation of mke2fs shows that the first fsync() on
> /dev/loop0 (in lib/ext2fs/closefs.c) which is failing with EIO.
>
> I haven't had a chance to really drill down on it, but I think what is
> going on is there is some former test which exercises an error path
> (using dm_error, or some such), and somehow the errseq_t for the loop
> device isn't getting reset, or the inode for the underlying backing
> file, had an unitialized errseq_t.
>
> Can you take a closer look at this?
>
> Thanks,
>
> - Ted
>
>
next prev parent reply other threads:[~2018-05-19 2:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 22:50 commit b4678df184b causing xfstests regressions Theodore Y. Ts'o
2018-05-19 2:17 ` Matthew Wilcox [this message]
2018-05-19 13:09 ` Jeff Layton
2018-05-19 15:25 ` Darrick J. Wong
2018-05-19 15:27 ` [PATCH] fs: clear writeback errors in inode_init_always Darrick J. Wong
2018-05-19 15:36 ` Matthew Wilcox
2018-05-21 17:54 ` Darrick J. Wong
2018-05-22 10:30 ` Jeff Layton
2018-05-22 22:09 ` Dave Chinner
2018-05-23 10:56 ` Jeff Layton
2018-05-24 3:59 ` Dave Chinner
2018-05-19 23:19 ` Theodore Y. Ts'o
2018-05-20 11:45 ` Jeff Layton
2018-05-20 12:58 ` Matthew Wilcox
2018-05-20 13:18 ` Jeff Layton
2018-05-20 16:29 ` Theodore Y. Ts'o
2018-05-20 19:20 ` Matthew Wilcox
2018-05-20 19:41 ` Theodore Y. Ts'o
2018-05-21 11:20 ` Jeff Layton
2018-05-21 14:43 ` Theodore Y. Ts'o
2018-05-20 17:57 ` Theodore Y. Ts'o
2018-05-22 4:06 ` [PATCH v2] " Darrick J. Wong
2018-05-22 10:14 ` Jeff Layton
2018-05-22 12:14 ` Brian Foster
2018-05-22 14:37 ` Darrick J. Wong
2018-05-22 16:43 ` [PATCH v3] " Darrick J. Wong
2018-05-22 18:40 ` Brian Foster
2018-05-22 18:47 ` Darrick J. Wong
2018-05-22 22:05 ` Dave Chinner
2018-05-23 3:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519021758.GA28858@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).