From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:43108 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030723AbeEZADE (ORCPT ); Fri, 25 May 2018 20:03:04 -0400 Date: Sat, 26 May 2018 01:03:02 +0100 From: Al Viro To: linux-fsdevel@vger.kernel.org Cc: Alexey Dobriyan Subject: [RFC][PATCHES] reducing d_add() use, part 3 (procfs) Message-ID: <20180526000302.GK30522@ZenIV.linux.org.uk> References: <20180513212612.GV30522@ZenIV.linux.org.uk> <20180525235326.GJ30522@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180525235326.GJ30522@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, May 26, 2018 at 12:53:26AM +0100, Al Viro wrote: > Continuation of the series - more simple cases: > openpromfs: switch to d_splice_alias() > orangefs_lookup: simplify > omfs_lookup(): report IO errors, use d_splice_alias() > hfs: use d_splice_alias() > hfs: don't allow mounting over .../rsrc > hfsplus: switch to d_splice_alias() > ncp_lookup(): use d_splice_alias() > 9p: unify paths in v9fs_vfs_lookup() > cifs_lookup(): cifs_get_inode_...() never returns 0 with *inode left NULL > cifs_lookup(): switch to d_splice_alias() ... and a lot more convoluted ones - procfs side. There we have a bloody misleading games around pid_revalidate() and friends; we do *NOT* need those for any kind of race protection anymore (and hadn't for years). However, these calls cannot be simply dropped - some of their side effects (namely, setting ownership and permissions) are needed. Separating those into common helpers used by revalidate and by lookups allows to untangle that mess. I would really like an ACK/NAK from Alexey on that part...