From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:46690 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750765AbeE1FSU (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 28 May 2018 01:18:20 -0400
Date: Mon, 28 May 2018 07:24:21 +0200
From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4/4] aio: fold do_io_submit() into callers
Message-ID: <20180528052421.GC2806@lst.de>
References: <20180527222730.GS30522@ZenIV.linux.org.uk> <20180527222853.30715-1-viro@ZenIV.linux.org.uk> <20180527222853.30715-4-viro@ZenIV.linux.org.uk> <20180527231413.GV30522@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180527231413.GV30522@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> -	if (unlikely(nr > LONG_MAX/sizeof(*iocbpp)))
> -		nr = LONG_MAX/sizeof(*iocbpp);

> +	if (nr > ctx->nr_events)
> +		nr = ctx->nr_events;

This seems like a slight behavior change.  What about splitting
that into a separate, properly document patch?

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>