From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 31 May 2018 15:36:43 -0600 From: Ross Zwisler To: Ross Zwisler , Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Jan Kara , Jeff Layton , Lukas Czerner , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Oleg Drokin , Andreas Dilger , James Simmons , Mike Kravetz Subject: Re: [PATCH v11 00/63] Convert page cache to XArray Message-ID: <20180531213643.GD28256@linux.intel.com> References: <20180414141316.7167-1-willy@infradead.org> <20180416160133.GA12434@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180416160133.GA12434@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: On Mon, Apr 16, 2018 at 10:01:33AM -0600, Ross Zwisler wrote: > On Sat, Apr 14, 2018 at 07:12:13AM -0700, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > This conversion keeps the radix tree and XArray data structures in sync > > at all times. That allows us to convert the page cache one function at > > a time and should allow for easier bisection. Other than renaming some > > elements of the structures, the data structures are fundamentally > > unchanged; a radix tree walk and an XArray walk will touch the same > > number of cachelines. I have changes planned to the XArray data > > structure, but those will happen in future patches. > > I've hit a few failures when throwing this into my test setup. The first two > seem like similar bugs hit in two different ways, the third seems unique. > I've verified that these don't seem to happen with the next-20180413 baseline. Hey Matthew, did you ever figure out these failures?