From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-db5eur01on0135.outbound.protection.outlook.com ([104.47.2.135]:45074 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964827AbeFNWWb (ORCPT ); Thu, 14 Jun 2018 18:22:31 -0400 Date: Thu, 14 Jun 2018 15:22:19 -0700 From: Andrey Vagin To: Al Viro Cc: Cyrill Gorcunov , Linux FS Devel Subject: Re: [1/4] vmsplice: lift import_iovec() into do_vmsplice() Message-ID: <20180614222218.GA8901@outlook.office365.com> References: <20180528222013.18402-1-viro@ZenIV.linux.org.uk> <20180606225751.GA1261@outlook.office365.com> <20180607175622.GA12359@outlook.office365.com> <20180611201656.GX30522@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20180611201656.GX30522@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 11, 2018 at 09:16:56PM +0100, Al Viro wrote: > On Mon, Jun 11, 2018 at 11:14:55PM +0300, Cyrill Gorcunov wrote: > > On Thu, Jun 7, 2018 at 10:07 PM Andrei Vagin wrote: > > > > > ... > > > > > + > > > > > + error = import_iovec(READ, uiov, nr_segs, > > > > > + ARRAY_SIZE(iovstack), &iov, &iter); > > > > > > > > import_iovec should be called with WRITE, if we are going to call > > > > vmsplice_to_pipe(). > > > > > > We caught this issue, when we run CRIU tests for > > > https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=for-next > > > > > > CRIU fails with errors like this: > > > > > > pie: 38: Error (criu/pie/parasite.c:89): Can't splice pages to pipe (-14/2/0) > > > > > It is already in the master tree, or still in the linux-next? > > Still in -next; I have a fixed variant, hadn't pushed it out yet. Al, can I ask you to push the fixed variant to -next or revert this one. We have a robot which regularly runs CRIU tests on -next, and now it is blocked by this issue. Thanks, Andrei