From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@redhat.com>,
Lukas Czerner <lczerner@redhat.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Christoph Hellwig <hch@lst.de>,
Goldwyn Rodrigues <rgoldwyn@suse.com>,
Nicholas Piggin <npiggin@gmail.com>,
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
linux-nilfs@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <yuchao0@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v14 00/74] Convert page cache to XArray
Date: Mon, 18 Jun 2018 21:12:57 -0600 [thread overview]
Message-ID: <20180619031257.GA12527@linux.intel.com> (raw)
In-Reply-To: <20180617020052.4759-1-willy@infradead.org>
On Sat, Jun 16, 2018 at 06:59:38PM -0700, Matthew Wilcox wrote:
> The XArray is a replacement for the radix tree. For the moment it uses
> the same data structures, enabling a gradual replacement. This patch
> set implements the XArray and converts the page cache to use it.
>
> A version of these patches has been running under xfstests for over
> 48 hours, so I have some confidence in them. The DAX changes have now
> also had a reasonable test outing. This is based on next-20180615 and
> is available as a git tree at
> git://git.infradead.org/users/willy/linux-dax.git xarray-20180615
>
> I shall create a git branch from -rc1 and ask for that to be included in
> -next. I'm a little concerned I still have no reviews on some of the
> later patches.
>
> Changes since v13:
> - Actually fixed bug in workingset conversion that led to exceptional
> entries not being deleted from the XArray. Not sure how I dropped
> that patch for v13. Thanks to David Sterba for noticing.
> - Fixed bug in DAX writeback conversion that failed to wake up waiters.
> Thanks to Ross for testing, and to Dan & Jeff for helping me get a
> setup working to reproduce the problem.
> - Converted the new dax_lock_page / dax_unlock_page functions.
> - Moved XArray test suite entirely into the test_xarray kernel module
> to match other test suites. It can still be built in userspace as
> part of the radix tree test suite.
> - Changed email address.
> - Moved a few functions into different patches to make the test-suite
> additions more logical.
> - Fixed a bug in XA_BUG_ON (oh the irony) where it evaluated the
> condition twice.
> - Constified xa_head() / xa_parent() / xa_entry() and their _locked
> variants.
> - Moved xa_parent() to xarray.h so it can be used from the workingset code.
> - Call the xarray testsuite from the radix tree test suite to ensure
> that I remember to run both test suites ;-)
> - Added some more tests to the test suite.
Hit another deadlock. This one reproduces 100% of the time in my setup with
XFS + DAX + generic/340. It doesn't reproduce for me at all with
next-20180615. Here's the output from "echo w > /proc/sysrq-trigger":
[ 92.849119] sysrq: SysRq : Show Blocked State
[ 92.850506] task PC stack pid father
[ 92.852299] holetest D 0 1651 1466 0x00000000
[ 92.853912] Call Trace:
[ 92.854610] __schedule+0x2c5/0xad0
[ 92.855612] schedule+0x36/0x90
[ 92.856602] get_unlocked_entry+0xce/0x120
[ 92.857756] ? dax_insert_entry+0x2b0/0x2b0
[ 92.858931] grab_mapping_entry+0x19e/0x250
[ 92.860119] dax_iomap_pte_fault+0x115/0x1140
[ 92.860836] dax_iomap_fault+0x37/0x40
[ 92.861235] __xfs_filemap_fault+0x2de/0x310
[ 92.861681] xfs_filemap_fault+0x2c/0x30
[ 92.862113] __do_fault+0x26/0x160
[ 92.862531] __handle_mm_fault+0xc96/0x1320
[ 92.863059] handle_mm_fault+0x1ba/0x3c0
[ 92.863534] __do_page_fault+0x2b4/0x590
[ 92.864029] do_page_fault+0x38/0x2c0
[ 92.864472] do_async_page_fault+0x2c/0xb0
[ 92.864985] ? async_page_fault+0x8/0x30
[ 92.865459] async_page_fault+0x1e/0x30
[ 92.865941] RIP: 0033:0x401442
[ 92.866322] Code: Bad RIP value.
[ 92.866739] RSP: 002b:00007fa29c9feec0 EFLAGS: 00010212
[ 92.867366] RAX: 00007fa29ca00400 RBX: 0000000000001000 RCX: 0000000000008000
[ 92.868219] RDX: 0000000000000009 RSI: 0000000000000000 RDI: 0000000000000000
[ 92.869082] RBP: 00007fa29c9ff700 R08: 00007fa29c9ff700 R09: 00007fa29c9ff700
[ 92.869939] R10: 0000000000000070 R11: 00007fa29e571ba0 R12: 00007fa29ca00000
[ 92.870804] R13: 00007fffd5f24160 R14: 0000000000000400 R15: 00007fffd5f240b0
This looks very similar to the one I reported last week with generic/269.
- Ross
next prev parent reply other threads:[~2018-06-19 3:12 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 1:59 [PATCH v14 00/74] Convert page cache to XArray Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 01/74] Update email address Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 02/74] radix tree test suite: Enable ubsan Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 03/74] dax: Fix use of zero page Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 04/74] xarray: Replace exceptional entries Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 05/74] xarray: Change definition of sibling entries Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 06/74] xarray: Add definition of struct xarray Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 07/74] xarray: Define struct xa_node Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 08/74] xarray: Add documentation Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 09/74] xarray: Add XArray load operation Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 10/74] xarray: Add XArray tags Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 11/74] xarray: Add XArray unconditional store operations Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 12/74] xarray: Add XArray conditional " Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 13/74] xarray: Add XArray iterators Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 14/74] xarray: Extract entries from an XArray Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 15/74] xarray: Destroy " Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 16/74] xarray: Step through " Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 17/74] xarray: Add xas_for_each_conflict Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 18/74] xarray: Add xas_create_range Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 19/74] xarray: Add MAINTAINERS entry Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 20/74] page cache: Rearrange address_space Matthew Wilcox
2018-06-17 1:59 ` [PATCH v14 21/74] page cache: Convert hole search to XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 22/74] page cache: Add and replace pages using the XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 23/74] page cache: Convert page deletion to XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 24/74] page cache: Convert find_get_entry " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 25/74] page cache: Convert find_get_entries " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 26/74] page cache: Convert find_get_pages_range " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 27/74] page cache: Convert find_get_pages_contig " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 28/74] page cache; Convert find_get_pages_range_tag " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 29/74] page cache: Convert find_get_entries_tag " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 30/74] page cache: Convert filemap_map_pages " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 31/74] radix tree test suite: Convert regression1 " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 32/74] page cache: Convert delete_batch " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 33/74] page cache: Remove stray radix comment Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 34/74] page cache: Convert filemap_range_has_page to XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 35/74] mm: Convert page-writeback " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 36/74] mm: Convert workingset " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 37/74] mm: Convert truncate " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 38/74] mm: Convert add_to_swap_cache " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 39/74] mm: Convert delete_from_swap_cache " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 40/74] mm: Convert __do_page_cache_readahead " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 41/74] mm: Convert page migration " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 42/74] mm: Convert huge_memory " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 43/74] mm: Convert collapse_shmem " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 44/74] mm: Convert khugepaged_scan_shmem " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 45/74] mm: Convert is_page_cache_freeable " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 46/74] pagevec: Use xa_tag_t Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 47/74] shmem: Convert shmem_radix_tree_replace to XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 48/74] shmem: Convert shmem_confirm_swap " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 49/74] shmem: Convert find_swap_entry " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 50/74] shmem: Convert shmem_add_to_page_cache " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 51/74] shmem: Convert shmem_alloc_hugepage " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 52/74] shmem: Convert shmem_free_swap " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 53/74] shmem: Convert shmem_partial_swap_usage " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 54/74] memfd: Convert memfd_wait_for_pins " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 55/74] memfd: Convert memfd_tag_pins " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 56/74] shmem: Comment fixups Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 57/74] btrfs: Convert page cache to XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 58/74] fs: Convert buffer " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 59/74] fs: Convert writeback " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 60/74] nilfs2: Convert " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 61/74] f2fs: " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 62/74] dax: Rename some functions Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 63/74] dax: Hash on XArray instead of mapping Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 64/74] dax: Convert dax_insert_pfn_mkwrite to XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 65/74] dax: Convert dax_layout_busy_page " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 66/74] dax: Convert __dax_invalidate_entry " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 67/74] dax: Convert dax writeback " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 68/74] dax: Convert dax_lock_page " Matthew Wilcox
2018-06-29 17:30 ` Ross Zwisler
2018-07-06 11:54 ` [PATCH] fs/dax: remove unused function Anders Roxell
2018-07-06 13:04 ` [PATCH v14 68/74] dax: Convert dax_lock_page to XArray Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 69/74] dax: Convert page fault handlers " Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 70/74] page cache: Finish XArray conversion Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 71/74] radix tree: Remove radix_tree_update_node_t Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 72/74] radix tree: Remove split/join code Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 73/74] radix tree: Remove radix_tree_maybe_preload_order Matthew Wilcox
2018-06-17 2:00 ` [PATCH v14 74/74] radix tree: Remove radix_tree_clear_tags Matthew Wilcox
2018-06-19 3:12 ` Ross Zwisler [this message]
2018-06-19 9:22 ` [PATCH v14 00/74] Convert page cache to XArray Matthew Wilcox
2018-06-19 16:40 ` Ross Zwisler
2018-06-19 17:16 ` Matthew Wilcox
2018-06-27 11:05 ` Matthew Wilcox
2018-06-27 19:44 ` Ross Zwisler
2018-06-28 8:39 ` Matthew Wilcox
2018-06-28 16:30 ` Ross Zwisler
2018-07-25 21:03 ` Matthew Wilcox
2018-07-25 21:12 ` Ross Zwisler
2018-07-27 17:20 ` Ross Zwisler
2018-07-30 15:43 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619031257.GA12527@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jlayton@redhat.com \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=lczerner@redhat.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=rgoldwyn@suse.com \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).