From: Matthew Wilcox <willy@infradead.org>
To: v9fs-developer@lists.sourceforge.net
Cc: linux-fsdevel@vger.kernel.org,
Eric Van Hensbergen <ericvh@gmail.com>,
Ron Minnich <rminnich@sandia.gov>,
Latchesar Ionkov <lucho@ionkov.net>,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>
Subject: [PATCH 4/6] 9p: Remove an unnecessary memory barrier
Date: Thu, 28 Jun 2018 06:26:27 -0700 [thread overview]
Message-ID: <20180628132629.3148-5-willy@infradead.org> (raw)
In-Reply-To: <20180628132629.3148-1-willy@infradead.org>
And add a comment about why we don't need it.
Signed-off-by: Matthew Wilcox <willy@infradead.org>
---
net/9p/client.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/9p/client.c b/net/9p/client.c
index 602f76de388a..2dce8d8307cc 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -436,13 +436,9 @@ void p9_client_cb(struct p9_client *c, struct p9_req_t *req, int status)
{
p9_debug(P9_DEBUG_MUX, " tag %d\n", req->tc->tag);
- /*
- * This barrier is needed to make sure any change made to req before
- * the other thread wakes up will indeed be seen by the waiting side.
- */
- smp_wmb();
req->status = status;
+ /* wake_up is an implicit write memory barrier */
wake_up(&req->wq);
p9_debug(P9_DEBUG_MUX, "wakeup: %d\n", req->tc->tag);
}
--
2.18.0
next prev parent reply other threads:[~2018-06-28 13:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 13:26 [PATCH 0/6] 9p: Use IDRs more effectively Matthew Wilcox
2018-06-28 13:26 ` [PATCH 1/6] 9p: Change p9_fid_create calling convention Matthew Wilcox
2018-06-28 13:26 ` [PATCH 2/6] 9p: Replace the fidlist with an IDR Matthew Wilcox
2018-07-11 12:40 ` [V9fs-developer] " Dominique Martinet
2018-07-11 12:52 ` Matthew Wilcox
2018-07-11 12:58 ` Dominique Martinet
2018-07-11 13:08 ` Matthew Wilcox
2018-06-28 13:26 ` [PATCH 3/6] 9p: Embed wait_queue_head into p9_req_t Matthew Wilcox
2018-06-28 13:26 ` Matthew Wilcox [this message]
2018-06-28 13:40 ` [V9fs-developer] [PATCH 4/6] 9p: Remove an unnecessary memory barrier Dominique Martinet
2018-06-28 14:03 ` Matthew Wilcox
2018-06-28 14:33 ` Dominique Martinet
2018-06-28 13:26 ` [PATCH 5/6] 9p: Use a slab for allocating requests Matthew Wilcox
2018-07-11 13:33 ` [V9fs-developer] " Dominique Martinet
2018-07-11 14:13 ` Matthew Wilcox
2018-07-11 14:24 ` Dominique Martinet
2018-06-28 13:26 ` [PATCH 6/6] 9p: Remove p9_idpool Matthew Wilcox
2018-07-11 13:38 ` [V9fs-developer] [PATCH 0/6] 9p: Use IDRs more effectively Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628132629.3148-5-willy@infradead.org \
--to=willy@infradead.org \
--cc=ericvh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).