From: Al Viro <viro@ZenIV.linux.org.uk>
To: zhong jiang <zhongjiang@huawei.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf: remove the same condition check
Date: Thu, 2 Aug 2018 04:04:43 +0100 [thread overview]
Message-ID: <20180802030442.GW30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1533175228-17547-1-git-send-email-zhongjiang@huawei.com>
On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote:
> dump_align is used to double check in a expression. It is redundant.
> so just remove one of them.
<mode eliza>
What makes you think that it is redundant?
</mode>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/binfmt_elf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> index efae2fb..b6c5b02 100644
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -1439,7 +1439,7 @@ static int writenote(struct memelfnote *men, struct coredump_params *cprm)
>
> return dump_emit(cprm, &en, sizeof(en)) &&
> dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) &&
> - dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4);
> + dump_emit(cprm, men->data, men->datasz);
> }
>
> static void fill_elf_header(struct elfhdr *elf, int segs,
> --
> 1.7.12.4
>
next prev parent reply other threads:[~2018-08-02 4:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 2:00 [PATCH] fs/binfmt_elf: remove the same condition check zhong jiang
2018-08-02 2:34 ` Matthew Wilcox
2018-08-02 3:24 ` zhong jiang
2018-08-02 3:04 ` Al Viro [this message]
2018-08-02 3:56 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802030442.GW30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).