From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, Avi Kivity <avi@scylladb.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] aio: implement IOCB_CMD_POLL
Date: Thu, 2 Aug 2018 11:22:34 +0200 [thread overview]
Message-ID: <20180802092234.GA13797@lst.de> (raw)
In-Reply-To: <20180802002121.GU30522@ZenIV.linux.org.uk>
On Thu, Aug 02, 2018 at 01:21:22AM +0100, Al Viro wrote:
> So what happens if
> * we call aio_poll(), add the sucker to queue and see that we need
> to wait
> * add to ->active_refs just as the wakeup comes
active_reqs I guess..
> * wakeup removes from queue and hits schedule_work()
> * io_cancel() is called, triggering aio_poll_cancel(), which sees that
> we are not from queue and buggers off. We are gone from ->active_refs.
> * aio_poll_complete_work() is called, sees no ->cancelled
> * aio_poll_complete_work() calls vfs_poll(), sees nothing interesting
> and puts us back on the queue.
So let me draw this up, we start with the following:
THREAD 1 THREAD 2
aio_poll
vfs_poll(...)
add_wait_queue()
(no pending mask)
spin_lock_irq(&ctx->ctx_lock);
list_add_tail(..., &ctx->active_reqs) aio_poll_wake
spin_unlock_irq(&ctx->ctx_lock);
(spin_trylock failed)
list_del_init(&req->wait.entry);
schedule_work(&req->work);
Now switching to two new threads:
io_cancel thread worker thread
vfs_poll()
(mask = 0)
aio_poll_cancel
(not on waitqueue, done)
remove from active_reqs
add_wait_queue()
iocb still around
>
> Unless I'm misreading it, cancel will end up with iocb still around and now
> impossible to cancel... What am I missing?
Yes, I think you are right. I'll see how I could handle that case.
One of the easiest options would be to just support aio poll on
file ops that support keyed wakeups, we'd just need to pass that
information up.
next prev parent reply other threads:[~2018-08-02 11:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:15 aio poll and a new in-kernel poll API V21 (aka 2.0) Christoph Hellwig
2018-07-30 7:15 ` [PATCH 1/4] timerfd: add support for keyed wakeups Christoph Hellwig
2018-07-30 7:15 ` [PATCH 2/4] aio: add a iocb refcount Christoph Hellwig
2018-08-01 23:19 ` Al Viro
2018-08-02 8:59 ` Christoph Hellwig
2018-07-30 7:15 ` [PATCH 3/4] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-08-01 23:54 ` Al Viro
2018-08-02 9:00 ` Christoph Hellwig
2018-08-02 0:21 ` Al Viro
2018-08-02 9:22 ` Christoph Hellwig [this message]
2018-08-02 16:00 ` Al Viro
2018-08-02 16:08 ` Christoph Hellwig
2018-08-02 16:08 ` Al Viro
2018-08-02 16:16 ` Christoph Hellwig
2018-08-02 21:48 ` Al Viro
2018-07-30 7:15 ` [PATCH 4/4] aio: allow direct aio poll comletions for keyed wakeups Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2018-08-06 8:30 aio poll V22 (aka 2.0) Christoph Hellwig
2018-08-06 8:30 ` [PATCH 3/4] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-07-26 8:28 aio poll and a new in-kernel poll API V20 (aka 2.0) Christoph Hellwig
2018-07-26 8:29 ` [PATCH 3/4] aio: implement IOCB_CMD_POLL Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802092234.GA13797@lst.de \
--to=hch@lst.de \
--cc=avi@scylladb.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).