From: Miklos Szeredi <mszeredi@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/6] fsmount: do not use legacy MS_ flags
Date: Thu, 20 Sep 2018 17:12:13 +0200 [thread overview]
Message-ID: <20180920151214.15484-6-mszeredi@redhat.com> (raw)
In-Reply-To: <20180920151214.15484-1-mszeredi@redhat.com>
What happens if we introduce new flags for fsmount(2) and are already out
of flags for mount(2)? I see a big mess that way.
So let's instead start a clean new set, to be used in the new API.
The MS_RELATIME flag was accepted but ignored. Simply leave this out of
the new set, since "relatime" is the default.
The MNT_ prefix is already used by libmount, and we don't want any
confusion arising from that. MOUNT_ feels a bit too long, so just go with
the short and sweet M_ prefix.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
fs/namespace.c | 28 +++++++++++++---------------
include/uapi/linux/mount.h | 9 +++++++++
2 files changed, 22 insertions(+), 15 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index 7671c1f6fc22..027b99b993c0 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -3332,7 +3332,7 @@ EXPORT_SYMBOL_GPL(kern_mount);
* Create a kernel mount representation for a new, prepared superblock
* (specified by fs_fd) and attach to an open_tree-like file descriptor.
*/
-SYSCALL_DEFINE3(fsmount, int, fs_fd, unsigned int, flags, unsigned int, ms_flags)
+SYSCALL_DEFINE3(fsmount, int, fs_fd, unsigned int, flags, unsigned int, m_flags)
{
struct fs_context *fc;
struct file *file;
@@ -3347,30 +3347,28 @@ SYSCALL_DEFINE3(fsmount, int, fs_fd, unsigned int, flags, unsigned int, ms_flags
if ((flags & ~(FSMOUNT_CLOEXEC)) != 0)
return -EINVAL;
- if (ms_flags & ~(MS_RDONLY | MS_NOSUID | MS_NODEV | MS_NOEXEC |
- MS_NOATIME | MS_NODIRATIME | MS_RELATIME |
- MS_STRICTATIME))
+ if (m_flags & ~(M_RDONLY | M_NOSUID | M_NODEV | M_NOEXEC |
+ M_NOATIME | M_STRICTATIME | M_NODIRATIME))
return -EINVAL;
- if (ms_flags & MS_RDONLY)
+ if ((m_flags & M_STRICTATIME) && (m_flags & M_NOATIME))
+ return -EINVAL;
+
+ if (m_flags & M_RDONLY)
mnt_flags |= MNT_READONLY;
- if (ms_flags & MS_NOSUID)
+ if (m_flags & M_NOSUID)
mnt_flags |= MNT_NOSUID;
- if (ms_flags & MS_NODEV)
+ if (m_flags & M_NODEV)
mnt_flags |= MNT_NODEV;
- if (ms_flags & MS_NOEXEC)
+ if (m_flags & M_NOEXEC)
mnt_flags |= MNT_NOEXEC;
- if (ms_flags & MS_NODIRATIME)
+ if (m_flags & M_NODIRATIME)
mnt_flags |= MNT_NODIRATIME;
- if (ms_flags & MS_STRICTATIME) {
- if (ms_flags & MS_NOATIME)
- return -EINVAL;
- } else if (ms_flags & MS_NOATIME) {
+ if (m_flags & M_NOATIME)
mnt_flags |= MNT_NOATIME;
- } else {
+ else if (!(m_flags & M_STRICTATIME))
mnt_flags |= MNT_RELATIME;
- }
f = fdget(fs_fd);
if (!f.file)
diff --git a/include/uapi/linux/mount.h b/include/uapi/linux/mount.h
index 3634e065836c..fce3513fc242 100644
--- a/include/uapi/linux/mount.h
+++ b/include/uapi/linux/mount.h
@@ -1,6 +1,15 @@
#ifndef _UAPI_LINUX_MOUNT_H
#define _UAPI_LINUX_MOUNT_H
+/* Mount flags passed to fsmount(2) */
+#define M_RDONLY 0x01
+#define M_NOSUID 0x02
+#define M_NODEV 0x04
+#define M_NOEXEC 0x08
+#define M_NOATIME 0x10
+#define M_STRICTATIME 0x20
+#define M_NODIRATIME 0x40
+
/*
* These are the fs-independent mount-flags: up to 32 flags are supported
*
--
2.14.3
next prev parent reply other threads:[~2018-09-20 20:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 15:12 [PATCH 0/6] mount-api: fixes and cleanups Miklos Szeredi
2018-09-20 15:12 ` [PATCH 1/6] selinux: fold superblock_doinit() into only caller Miklos Szeredi
2018-09-20 15:12 ` [PATCH 2/6] vfs_submount: use SB_SUBMOUNT instead of MS_SUBMOUNT Miklos Szeredi
2018-09-20 15:12 ` [PATCH 3/6] mount: fix regression in setting "subtype" from legacy API Miklos Szeredi
2018-09-20 15:12 ` [PATCH 4/6] fsconfig: parse "subtype" param for old internal API Miklos Szeredi
2018-09-20 15:12 ` Miklos Szeredi [this message]
2018-09-20 15:12 ` [PATCH 6/6] fsconfig: rename FSCONFIG_CMD_CREATE to FSCONFIG_CMD_OBTAIN Miklos Szeredi
2018-09-21 14:41 ` [PATCH 1/6] selinux: fold superblock_doinit() into only caller David Howells
2018-09-21 14:45 ` [PATCH 2/6] vfs_submount: use SB_SUBMOUNT instead of MS_SUBMOUNT David Howells
2018-09-21 14:52 ` [PATCH 3/6] mount: fix regression in setting "subtype" from legacy API David Howells
2018-09-21 14:56 ` [PATCH 4/6] fsconfig: parse "subtype" param for old internal API David Howells
2018-09-21 15:07 ` [PATCH 5/6] fsmount: do not use legacy MS_ flags David Howells
2018-09-21 15:28 ` Miklos Szeredi
2018-09-21 15:37 ` David Howells
2018-09-21 15:54 ` Christian Brauner
2018-09-21 16:52 ` David Howells
2018-09-22 13:21 ` Christian Brauner
2018-09-22 15:48 ` David Howells
2018-09-22 16:14 ` Christian Brauner
2018-09-23 22:45 ` David Howells
2018-09-23 23:01 ` Christian Brauner
2018-09-24 6:50 ` David Howells
2018-09-24 9:47 ` Christian Brauner
2018-09-24 12:37 ` David Howells
2018-09-24 13:18 ` Christian Brauner
2018-09-21 15:11 ` [PATCH 6/6] fsconfig: rename FSCONFIG_CMD_CREATE to FSCONFIG_CMD_OBTAIN David Howells
2018-09-21 15:23 ` Miklos Szeredi
2018-09-21 16:44 ` [PATCH 0/6] mount-api: fixes and cleanups David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920151214.15484-6-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).