From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Colin King <colin.king@canonical.com>,
linux-fsdevel@vger.kernel.org, dhowells@redhat.com,
viro@zeniv.linux.org.uk, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vyacheslav Dubeyko <slava@dubeyko.com>
Subject: Re: [PATCH] hfs: fix array out of bounds read of array extent
Date: Wed, 17 Oct 2018 20:28:20 -0300 [thread overview]
Message-ID: <20181017232820.dyvl7crdlilcqtaw@eaf> (raw)
In-Reply-To: <20181017150117.fef4f8d8e814aa2d25adba5e@linux-foundation.org>
On Wed, Oct 17, 2018 at 03:01:17PM -0700, Andrew Morton wrote:
> On Fri, 31 Aug 2018 15:05:38 +0100 Colin King <colin.king@canonical.com> wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently extent and index i are both being incremented causing
> > an array out of bounds read on extent[i]. Fix this by removing
> > the extraneous increment of extent.
> >
> > Detected by CoverityScan, CID#711541 ("Out of bounds read")
> >
> > Fixes: d1081202f1d0 ("HFS rewrite")
>
> No such commit here. I assume this is 7cb74be6fd827e314f8.
Sorry, I missed that. This bug has actually been here since before the
first git commit.
>
> > --- a/fs/hfs/extent.c
> > +++ b/fs/hfs/extent.c
> > @@ -300,7 +300,7 @@ int hfs_free_fork(struct super_block *sb, struct hfs_cat_file *file, int type)
> > return 0;
> >
> > blocks = 0;
> > - for (i = 0; i < 3; extent++, i++)
> > + for (i = 0; i < 3; i++)
> > blocks += be16_to_cpu(extent[i].count);
> >
> > res = hfs_free_extents(sb, extent, blocks, blocks);
>
> Well, that's quite the bug. Question is, why didn't anyone notice it.
> What are the runtime effects?
This is only triggered when deleting a file with a resource fork. I may
be wrong because the documentation isn't clear, but I don't think you can
create those under linux. So I guess nobody was testing them.
> A disk space leak, perhaps?
That's what it looks like in general. hfs_free_extents() won't do anything
if the block count doesn't add up, and the error will be ignored. Now, if
the block count randomly does add up, we could see some corruption.
> I worry a bit that, given the fs was evidently working "ok", perhaps
> this error was corrected elsewhere in the code and that "fixing" this
> site will have unexpected and undesirable runtime effects. Can someone
> help me out here?
I don't think so. This bug also makes extent point to the wrong place on
the following call to hfs_free_extents(). There is no way this can work
correctly in general.
next prev parent reply other threads:[~2018-10-18 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 14:05 [PATCH] hfs: fix array out of bounds read of array extent Colin King
2018-10-17 17:49 ` Ernesto A. Fernández
[not found] ` <20181017150117.fef4f8d8e814aa2d25adba5e@linux-foundation.org>
2018-10-17 23:17 ` Al Viro
2018-10-17 23:28 ` Ernesto A. Fernández [this message]
2018-10-17 23:36 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017232820.dyvl7crdlilcqtaw@eaf \
--to=ernesto.mnd.fernandez@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).