From: Eric Biggers <ebiggers@kernel.org>
To: linux-fsdevel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static
Date: Thu, 7 Feb 2019 15:39:41 -0800 [thread overview]
Message-ID: <20190207233940.GH125156@gmail.com> (raw)
In-Reply-To: <20190110204147.120073-1-ebiggers@kernel.org>
On Thu, Jan 10, 2019 at 12:41:47PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> to_mnt_ns() is only used in fs/namespace.c, so make it static.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index a677b59efd74e..2ba0dbd8573a2 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1688,7 +1688,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
> dentry->d_fsdata == &mntns_operations;
> }
>
> -struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> {
> return container_of(ns, struct mnt_namespace, ns);
> }
> --
> 2.20.1.97.g81188d93c3-goog
>
Ping. Al, are you planning to apply this?
- Eric
next prev parent reply other threads:[~2019-02-07 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 20:41 [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static Eric Biggers
2019-02-07 23:39 ` Eric Biggers [this message]
2019-08-22 15:40 Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207233940.GH125156@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).