From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F92AC169C4 for ; Mon, 11 Feb 2019 12:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A0FC218D8 for ; Mon, 11 Feb 2019 12:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbfBKM5K (ORCPT ); Mon, 11 Feb 2019 07:57:10 -0500 Received: from verein.lst.de ([213.95.11.211]:56529 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727106AbfBKM5K (ORCPT ); Mon, 11 Feb 2019 07:57:10 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 4B27668DD6; Mon, 11 Feb 2019 13:57:08 +0100 (CET) Date: Mon, 11 Feb 2019 13:57:08 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: Andreas Dilger , "Darrick J. Wong" , linux-fsdevel , Christoph Hellwig , Eric Sandeen , david@fromorbit.com Subject: Re: [PATCH 09/10 V2] Use FIEMAP for FIBMAP calls Message-ID: <20190211125708.GA21583@lst.de> References: <20181205091728.29903-1-cmaiolino@redhat.com> <20181205091728.29903-10-cmaiolino@redhat.com> <20181205173650.GA8112@magnolia> <20190204151147.rra4n7k56ec4ndob@hades.usersys.redhat.com> <20190204182722.GA32119@magnolia> <20190206133753.oqpw7citye6apdpr@hades.usersys.redhat.com> <20190206204431.GB32119@magnolia> <0258844F-A305-4744-8C70-B27A3E49ADEC@dilger.ca> <20190207095233.imqha36zgoqilxx2@hades.usersys.redhat.com> <20190208084352.GA23194@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190208084352.GA23194@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Feb 08, 2019 at 09:43:52AM +0100, Christoph Hellwig wrote: > Agreed. Please don't change the FIEMAP uapi. If we need to check > for a request coming from bmap just defined an internal FIEMAP flag > as the last available flag in the flags word, and reject it when > it comes from userspace in fiemap. Based on the new thread you started it seems like this go lost. I think we are 99% done with the bmap through fiemap series, and it is just missing this internal flag to make progress. Let's finish this off before starting another big project in the area.