From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jeremy Cline <jcline@redhat.com>
Cc: David Both <dboth@millennium-technology.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: update i_atime when reading files
Date: Mon, 25 Feb 2019 22:47:30 +0300 [thread overview]
Message-ID: <20190225194627.GA14348@avx2> (raw)
In-Reply-To: <20190222150020.GA14465@laptop.jcline.org>
On Fri, Feb 22, 2019 at 10:00:20AM -0500, Jeremy Cline wrote:
> On Fri, Feb 22, 2019 at 08:37:42AM +0300, Alexey Dobriyan wrote:
> > On Thu, Feb 21, 2019 at 11:37:14AM -0500, Jeremy Cline wrote:
> > > Prior to commit 1da4d377f943 ("proc: revalidate misc dentries"), the
> > > access, modify, and change times of files in /proc were just the current
> > > time.
> >
> > Ehh, actually no. Doing
> >
> > $(which sleep) infinity </proc/foo &
> >
> > will sabotage atime updates because dentry and inode will be pinned in
> > caches.
> >
> > "revalidate misc denries" commit simply makes the effect (much) more
> > visible by making objects stay in caches for longer.
>
> Indeed. It wasn't my intention to imply there's anything wrong with that
> commit, just that that's what caused this apparent change in behavior
> for users. In the "common" case when something hasn't pinned the dentry
> and inode what users saw was the current time.
>
> >
> > > Now the mtime and ctime values change mostly as a user would
> > > expect, but the atime isn't updated when the file read. This patch
> > > updates the access time of /proc files when they are read.
> >
> > > rv = read(file, buf, count, ppos);
> > > + if (rv >= 0)
> > > + inode->i_atime = current_time(inode);
> > > + }
> >
> > Maybe it should be done given /proc is virtual so there are no concerns
> > about scheduling writes noone cares about to the filesystem.
>
> Sorry, maybe I've not had enough coffee yet, but I don't understand this
> sentence.
I meant it should be harmless to enable atime unconditionally for /proc
because it is virtual filesystem.
prev parent reply other threads:[~2019-02-25 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 16:37 [PATCH] proc: update i_atime when reading files Jeremy Cline
2019-02-22 5:37 ` Alexey Dobriyan
2019-02-22 15:00 ` Jeremy Cline
2019-02-25 19:47 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225194627.GA14348@avx2 \
--to=adobriyan@gmail.com \
--cc=dboth@millennium-technology.com \
--cc=jcline@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).