From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB48C43381 for ; Tue, 26 Feb 2019 09:33:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EB0421848 for ; Tue, 26 Feb 2019 09:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727506AbfBZJdX (ORCPT ); Tue, 26 Feb 2019 04:33:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53490 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727462AbfBZJdX (ORCPT ); Tue, 26 Feb 2019 04:33:23 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C9A5081E00; Tue, 26 Feb 2019 09:33:21 +0000 (UTC) Received: from ming.t460p (ovpn-8-35.pek2.redhat.com [10.72.8.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 75BEC5C66B; Tue, 26 Feb 2019 09:33:08 +0000 (UTC) Date: Tue, 26 Feb 2019 17:33:04 +0800 From: Ming Lei To: Dave Chinner Cc: Matthew Wilcox , Vlastimil Babka , "Darrick J . Wong" , linux-xfs@vger.kernel.org, Jens Axboe , Vitaly Kuznetsov , Dave Chinner , Christoph Hellwig , Alexander Duyck , Aaron Lu , Christopher Lameter , Linux FS Devel , linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH] xfs: allocate sector sized IO buffer via page_frag_alloc Message-ID: <20190226093302.GA24879@ming.t460p> References: <20190225040904.5557-1-ming.lei@redhat.com> <20190225043648.GE23020@dastard> <5ad2ef83-8b3a-0a15-d72e-72652b807aad@suse.cz> <20190225202630.GG23020@dastard> <20190226022249.GA17747@ming.t460p> <20190226030214.GI23020@dastard> <20190226032737.GA11592@bombadil.infradead.org> <20190226045826.GJ23020@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190226045826.GJ23020@dastard> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 26 Feb 2019 09:33:23 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 26, 2019 at 03:58:26PM +1100, Dave Chinner wrote: > On Mon, Feb 25, 2019 at 07:27:37PM -0800, Matthew Wilcox wrote: > > On Tue, Feb 26, 2019 at 02:02:14PM +1100, Dave Chinner wrote: > > > > Or what is the exact size of sub-page IO in xfs most of time? For > > > > > > Determined by mkfs parameters. Any power of 2 between 512 bytes and > > > 64kB needs to be supported. e.g: > > > > > > # mkfs.xfs -s size=512 -b size=1k -i size=2k -n size=8k .... > > > > > > will have metadata that is sector sized (512 bytes), filesystem > > > block sized (1k), directory block sized (8k) and inode cluster sized > > > (32k), and will use all of them in large quantities. > > > > If XFS is going to use each of these in large quantities, then it doesn't > > seem unreasonable for XFS to create a slab for each type of metadata? > > > Well, that is the question, isn't it? How many other filesystems > will want to make similar "don't use entire pages just for 4k of > metadata" optimisations as 64k page size machines become more > common? There are others that have the same "use slab for sector > aligned IO" which will fall foul of the same problem that has been > reported for XFS.... > > If nobody else cares/wants it, then it can be XFS only. But it's > only fair we address the "will it be useful to others" question > first..... This kind of slab cache should have been global, just like interface of kmalloc(size). However, the alignment requirement depends on block device's block size, then it becomes hard to implement as genera interface, for example: block size: 512, 1024, 2048, 4096 slab size: 512*N, 0 < N < PAGE_SIZE/512 For 4k page size, 28(7*4) slabs need to be created, and 64k page size needs to create 127*4 slabs. But, specific file system may only use some of them, and it depends on meta data size. Thanks, Ming