From: Christian Brauner <christian@brauner.io>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Jann Horn <jannh@google.com>, Oleg Nesterov <oleg@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
kernel list <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Steven Rostedt <rostedt@goodmis.org>,
Daniel Colascione <dancol@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrei Vagin <avagin@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kselftest@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Nadav Amit <namit@vmware.com>, Serge Hallyn <serge@hallyn.com>,
Shuah Khan <shuah@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Taehee Yoo <ap420073@gmail.com>, Tejun Heo <tj@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
kernel-team <kernel-team@android.com>,
Tycho Andersen <tycho@tycho.ws>
Subject: Re: [PATCH RFC 1/2] Add polling support to pidfd
Date: Fri, 19 Apr 2019 21:42:04 +0200 [thread overview]
Message-ID: <20190419194203.am6ci63rpwsnchzg@brauner.io> (raw)
In-Reply-To: <20190419192233.d2n6al7hgoga6gts@brauner.io>
On Fri, Apr 19, 2019 at 09:22:33PM +0200, Christian Brauner wrote:
> On Fri, Apr 19, 2019 at 09:18:58PM +0200, Christian Brauner wrote:
> > On Fri, Apr 19, 2019 at 03:02:47PM -0400, Joel Fernandes wrote:
> > > On Thu, Apr 18, 2019 at 07:26:44PM +0200, Christian Brauner wrote:
> > > > On April 18, 2019 7:23:38 PM GMT+02:00, Jann Horn <jannh@google.com> wrote:
> > > > >On Wed, Apr 17, 2019 at 3:09 PM Oleg Nesterov <oleg@redhat.com> wrote:
> > > > >> On 04/16, Joel Fernandes wrote:
> > > > >> > On Tue, Apr 16, 2019 at 02:04:31PM +0200, Oleg Nesterov wrote:
> > > > >> > >
> > > > >> > > Could you explain when it should return POLLIN? When the whole
> > > > >process exits?
> > > > >> >
> > > > >> > It returns POLLIN when the task is dead or doesn't exist anymore,
> > > > >or when it
> > > > >> > is in a zombie state and there's no other thread in the thread
> > > > >group.
> > > > >>
> > > > >> IOW, when the whole thread group exits, so it can't be used to
> > > > >monitor sub-threads.
> > > > >>
> > > > >> just in case... speaking of this patch it doesn't modify
> > > > >proc_tid_base_operations,
> > > > >> so you can't poll("/proc/sub-thread-tid") anyway, but iiuc you are
> > > > >going to use
> > > > >> the anonymous file returned by CLONE_PIDFD ?
> > > > >
> > > > >I don't think procfs works that way. /proc/sub-thread-tid has
> > > > >proc_tgid_base_operations despite not being a thread group leader.
> > > > >(Yes, that's kinda weird.) AFAICS the WARN_ON_ONCE() in this code can
> > > > >be hit trivially, and then the code will misbehave.
> > > > >
> > > > >@Joel: I think you'll have to either rewrite this to explicitly bail
> > > > >out if you're dealing with a thread group leader, or make the code
> > > > >work for threads, too.
> > > >
> > > > The latter case probably being preferred if this API is supposed to be
> > > > useable for thread management in userspace.
> > >
> > > At the moment, we are not planning to use this for sub-thread management. I
> > > am reworking this patch to only work on clone(2) pidfds which makes the above
> >
> > Indeed and agreed.
> >
> > > discussion about /proc a bit unnecessary I think. Per the latest CLONE_PIDFD
> > > patches, CLONE_THREAD with pidfd is not supported.
> >
> > Yes. We have no one asking for it right now and we can easily add this
> > later.
> >
> > Admittedly I haven't gotten around to reviewing the patches here yet
> > completely. But one thing about using POLLIN. FreeBSD is using POLLHUP
> > on process exit which I think is nice as well. How about returning
> > POLLIN | POLLHUP on process exit?
> > We already do things like this. For example, when you proxy between
> > ttys. If the process that you're reading data from has exited and closed
> > it's end you still can't usually simply exit because it might have still
> > buffered data that you want to read. The way one can deal with this
> > from userspace is that you can observe a (POLLHUP | POLLIN) event and
> > you keep on reading until you only observe a POLLHUP without a POLLIN
> > event at which point you know you have read
> > all data.
> > I like the semantics for pidfds as well as it would indicate:
> > - POLLHUP -> process has exited
>
> or POLLRDHUP. The check you'd usually perform would probably be
> if ((revents & (POLLIN | POLLPRI)) > 0) && ((revents & (POLLHUP | POLLRDHUP)) > 0)
> /* keep on trying to read */
>
> I guess you have that set of flags already suggested in another mail?
The code where this pattern is e.g. used is in drivers/tty/n_tty.c:
static __poll_t n_tty_poll(struct tty_struct *tty, struct file *file,
poll_table *wait)
{
__poll_t mask = 0;
poll_wait(file, &tty->read_wait, wait);
poll_wait(file, &tty->write_wait, wait);
if (input_available_p(tty, 1))
mask |= EPOLLIN | EPOLLRDNORM;
else {
tty_buffer_flush_work(tty->port);
if (input_available_p(tty, 1))
mask |= EPOLLIN | EPOLLRDNORM;
}
if (tty->packet && tty->link->ctrl_status)
mask |= EPOLLPRI | EPOLLIN | EPOLLRDNORM;
if (test_bit(TTY_OTHER_CLOSED, &tty->flags))
mask |= EPOLLHUP;
if (tty_hung_up_p(file))
mask |= EPOLLHUP;
if (tty->ops->write && !tty_is_writelocked(tty) &&
tty_chars_in_buffer(tty) < WAKEUP_CHARS &&
tty_write_room(tty) > 0)
mask |= EPOLLOUT | EPOLLWRNORM;
return mask;
}
next prev parent reply other threads:[~2019-04-19 19:42 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 17:50 [PATCH RFC 1/2] Add polling support to pidfd Joel Fernandes (Google)
2019-04-11 17:50 ` [PATCH RFC 2/2] Add selftests for pidfd polling Joel Fernandes (Google)
2019-04-12 14:51 ` Tycho Andersen
2019-04-11 20:00 ` [PATCH RFC 1/2] Add polling support to pidfd Joel Fernandes
2019-04-11 20:02 ` Christian Brauner
2019-04-11 20:20 ` Joel Fernandes
2019-04-12 21:32 ` Andy Lutomirski
2019-04-13 0:09 ` Joel Fernandes
[not found] ` <CAKOZuetX4jMPDtDqAvGgSNo4BHf9BOnu79ufEiULfM5X5nDyyQ@mail.gmail.com>
2019-04-13 0:56 ` Daniel Colascione
2019-04-14 18:19 ` Linus Torvalds
2019-04-16 12:04 ` Oleg Nesterov
2019-04-16 12:43 ` Oleg Nesterov
2019-04-16 19:20 ` Joel Fernandes
2019-04-16 19:32 ` Joel Fernandes
2019-04-17 13:09 ` Oleg Nesterov
2019-04-18 17:23 ` Jann Horn
2019-04-18 17:26 ` Christian Brauner
2019-04-18 17:53 ` Daniel Colascione
2019-04-19 19:02 ` Joel Fernandes
2019-04-19 19:18 ` Christian Brauner
2019-04-19 19:22 ` Christian Brauner
2019-04-19 19:42 ` Christian Brauner [this message]
2019-04-19 19:49 ` Joel Fernandes
2019-04-19 20:01 ` Christian Brauner
2019-04-19 21:13 ` Joel Fernandes
2019-04-19 20:34 ` Daniel Colascione
2019-04-19 20:57 ` Christian Brauner
2019-04-19 21:20 ` Joel Fernandes
2019-04-19 21:24 ` Daniel Colascione
2019-04-19 21:45 ` Joel Fernandes
2019-04-19 22:08 ` Daniel Colascione
2019-04-19 22:17 ` Christian Brauner
2019-04-19 22:37 ` Daniel Colascione
2019-04-24 8:04 ` Enrico Weigelt, metux IT consult
2019-04-19 21:59 ` Christian Brauner
2019-04-20 11:51 ` Oleg Nesterov
2019-04-20 12:26 ` Oleg Nesterov
2019-04-20 12:35 ` Christian Brauner
2019-04-19 23:11 ` Linus Torvalds
2019-04-19 23:20 ` Christian Brauner
2019-04-19 23:32 ` Linus Torvalds
2019-04-19 23:36 ` Daniel Colascione
2019-04-20 0:46 ` Joel Fernandes
2019-04-19 21:21 ` Daniel Colascione
2019-04-19 21:48 ` Christian Brauner
2019-04-19 22:02 ` Christian Brauner
2019-04-19 22:46 ` Daniel Colascione
2019-04-19 23:12 ` Christian Brauner
2019-04-19 23:46 ` Daniel Colascione
2019-04-20 0:17 ` Christian Brauner
2019-04-24 9:05 ` Enrico Weigelt, metux IT consult
2019-04-24 9:03 ` Enrico Weigelt, metux IT consult
2019-04-19 22:35 ` Daniel Colascione
2019-04-19 23:02 ` Christian Brauner
2019-04-19 23:29 ` Daniel Colascione
2019-04-20 0:02 ` Christian Brauner
2019-04-24 9:17 ` Enrico Weigelt, metux IT consult
2019-04-24 9:11 ` Enrico Weigelt, metux IT consult
2019-04-24 8:56 ` Enrico Weigelt, metux IT consult
2019-04-24 8:20 ` Enrico Weigelt, metux IT consult
2019-04-19 15:43 ` Oleg Nesterov
2019-04-19 18:12 ` Joel Fernandes
2019-04-18 18:44 ` Jonathan Kowalski
2019-04-18 18:57 ` Daniel Colascione
2019-04-18 19:14 ` Linus Torvalds
2019-04-19 19:05 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419194203.am6ci63rpwsnchzg@brauner.io \
--to=christian@brauner.io \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=avagin@gmail.com \
--cc=dancol@google.com \
--cc=ebiederm@xmission.com \
--cc=fweimer@redhat.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mhocko@suse.com \
--cc=namit@vmware.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=serge@hallyn.com \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).