From: Miklos Szeredi <mszeredi@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Ian Kent <raven@themaw.net>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 06/13] vfs: new helper: vfs_parse_ro_rw()
Date: Wed, 19 Jun 2019 14:30:12 +0200 [thread overview]
Message-ID: <20190619123019.30032-6-mszeredi@redhat.com> (raw)
In-Reply-To: <20190619123019.30032-1-mszeredi@redhat.com>
This just parses the "ro" and "rw" options and sets sb_flags accordingly.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
fs/fs_context.c | 18 ++++++++++++++++++
include/linux/fs_context.h | 1 +
2 files changed, 19 insertions(+)
diff --git a/fs/fs_context.c b/fs/fs_context.c
index c26b353aa858..5012ab7650ec 100644
--- a/fs/fs_context.c
+++ b/fs/fs_context.c
@@ -77,6 +77,24 @@ int vfs_parse_sb_flag(struct fs_context *fc, struct fs_parameter *param)
}
EXPORT_SYMBOL(vfs_parse_sb_flag);
+int vfs_parse_ro_rw(struct fs_context *fc, struct fs_parameter *param)
+{
+ if (strcmp(param->key, "ro") == 0)
+ fc->sb_flags |= SB_RDONLY;
+ else if (strcmp(param->key, "rw") == 0)
+ fc->sb_flags &= ~SB_RDONLY;
+ else
+ return -ENOPARAM;
+
+ if (param->type != fs_value_is_flag)
+ return invalf(fc, "%s: Unexpected value for '%s'",
+ fc->fs_type->name, param->key);
+
+ fc->sb_flags_mask |= SB_RDONLY;
+ return 0;
+}
+EXPORT_SYMBOL(vfs_parse_ro_rw);
+
/**
* vfs_parse_fs_param - Add a single parameter to a superblock config
* @fc: The filesystem context to modify
diff --git a/include/linux/fs_context.h b/include/linux/fs_context.h
index 39f4d8b0a390..bff6796a89ef 100644
--- a/include/linux/fs_context.h
+++ b/include/linux/fs_context.h
@@ -128,6 +128,7 @@ extern struct fs_context *fs_context_for_submount(struct file_system_type *fs_ty
extern struct fs_context *vfs_dup_fs_context(struct fs_context *fc);
extern int vfs_parse_sb_flag(struct fs_context *fc, struct fs_parameter *param);
+extern int vfs_parse_ro_rw(struct fs_context *fc, struct fs_parameter *param);
extern int vfs_parse_fs_param(struct fs_context *fc, struct fs_parameter *param);
extern int vfs_parse_fs_string(struct fs_context *fc, const char *key,
const char *value, size_t v_size);
--
2.21.0
next prev parent reply other threads:[~2019-06-19 12:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 12:30 [PATCH 01/13] vfs: verify param type in vfs_parse_sb_flag() Miklos Szeredi
2019-06-19 12:30 ` [PATCH 02/13] vfs: move vfs_parse_sb_flag() calls into filesystems Miklos Szeredi
2019-06-19 12:30 ` [PATCH 03/13] vfs: don't parse forbidden flags Miklos Szeredi
2019-06-19 12:30 ` [PATCH 04/13] vfs: don't parse "posixacl" option Miklos Szeredi
2019-06-19 12:30 ` [PATCH 05/13] vfs: don't parse "silent" option Miklos Szeredi
2019-06-20 4:40 ` Ian Kent
2019-06-24 8:25 ` Miklos Szeredi
2019-06-24 10:36 ` David Howells
2019-06-24 10:44 ` Miklos Szeredi
2019-06-24 10:53 ` Miklos Szeredi
2019-06-19 12:30 ` Miklos Szeredi [this message]
2019-06-19 12:30 ` [PATCH 07/13] proc: don't ignore options Miklos Szeredi
2019-06-19 12:30 ` [PATCH 08/13] sysfs: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 09/13] mqueue: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 10/13] cpuset: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 11/13] cgroup: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 12/13] fusectl: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 13/13] resctrl: " Miklos Szeredi
2019-07-01 8:45 ` [PATCH 01/13] vfs: verify param type in vfs_parse_sb_flag() Miklos Szeredi
2019-07-04 16:19 ` David Howells
2019-09-06 7:28 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619123019.30032-6-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).