From: Eric Biggers <ebiggers@kernel.org>
To: Jaskaran Khurana <jaskarankhurana@linux.microsoft.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-fsdevel@vger.kernel.org, agk@redhat.com,
snitzer@redhat.com, dm-devel@redhat.com, jmorris@namei.org,
scottsh@microsoft.com, mpatocka@redhat.com, gmazyland@gmail.com
Subject: Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.
Date: Thu, 27 Jun 2019 16:41:50 -0700 [thread overview]
Message-ID: <20190627234149.GA212823@gmail.com> (raw)
In-Reply-To: <20190619191048.20365-2-jaskarankhurana@linux.microsoft.com>
Hi Jaskaran, one comment (I haven't reviewed this in detail):
On Wed, Jun 19, 2019 at 12:10:48PM -0700, Jaskaran Khurana wrote:
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index db269a348b20..2d658a3512cb 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -475,6 +475,7 @@ config DM_VERITY
> select CRYPTO
> select CRYPTO_HASH
> select DM_BUFIO
> + select SYSTEM_DATA_VERIFICATION
> ---help---
> This device-mapper target creates a read-only device that
> transparently validates the data on one underlying device against
> diff --git a/drivers/md/Makefile b/drivers/md/Makefile
> index be7a6eb92abc..3b47b256b15e 100644
> --- a/drivers/md/Makefile
> +++ b/drivers/md/Makefile
> @@ -18,7 +18,7 @@ dm-cache-y += dm-cache-target.o dm-cache-metadata.o dm-cache-policy.o \
> dm-cache-background-tracker.o
> dm-cache-smq-y += dm-cache-policy-smq.o
> dm-era-y += dm-era-target.o
> -dm-verity-y += dm-verity-target.o
> +dm-verity-y += dm-verity-target.o dm-verity-verify-sig.o
> md-mod-y += md.o md-bitmap.o
> raid456-y += raid5.o raid5-cache.o raid5-ppl.o
> dm-zoned-y += dm-zoned-target.o dm-zoned-metadata.o dm-zoned-reclaim.o
Perhaps this should be made optional and controlled by a kconfig option
CONFIG_DM_VERITY_SIGNATURE_VERIFICATION, similar to CONFIG_DM_VERITY_FEC?
CONFIG_SYSTEM_DATA_VERIFICATION brings in a lot of stuff, which might be
unnecessary for some dm-verity users. Also, you've already separated most of
the code out into a separate .c file anyway.
- Eric
next prev parent reply other threads:[~2019-06-27 23:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 19:10 [RFC PATCH v5 0/1] Add dm verity root hash pkcs7 sig validation Jaskaran Khurana
2019-06-19 19:10 ` [RFC PATCH v5 1/1] " Jaskaran Khurana
2019-06-25 18:20 ` Mike Snitzer
2019-06-26 5:48 ` Milan Broz
2019-08-13 18:49 ` Jaskaran Singh Khurana
2019-06-27 12:17 ` Milan Broz
2019-06-28 1:52 ` Jaskaran Singh Khurana
2019-06-27 23:41 ` Eric Biggers [this message]
2019-06-28 1:49 ` Jaskaran Singh Khurana
2019-06-28 3:00 ` Eric Biggers
2019-06-28 5:12 ` Milan Broz
2019-06-28 17:03 ` Jaskaran Singh Khurana
2019-06-28 4:00 ` [RFC PATCH v5 0/1] " Eric Biggers
2019-06-28 19:45 ` Jaskaran Singh Khurana
2019-06-28 20:34 ` Eric Biggers
2019-06-28 23:27 ` Jaskaran Singh Khurana
2019-06-29 4:01 ` James Morris
2019-07-01 9:41 ` Milan Broz
2019-07-01 17:33 ` Jaskaran Singh Khurana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627234149.GA212823@gmail.com \
--to=ebiggers@kernel.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=jaskarankhurana@linux.microsoft.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=scottsh@microsoft.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).