Re: Merging virtualbox shared-folder VFS driver through drivers/staging?

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Aug 11, 2019 at 03:43:01PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 8/11/19 9:50 AM, Greg Kroah-Hartman wrote:
> > On Sun, Aug 11, 2019 at 12:43:48AM -0700, Christoph Hellwig wrote:
> > > On Sun, Aug 11, 2019 at 09:40:05AM +0200, Greg Kroah-Hartman wrote:
> > > > > Since I do not see the lack of reviewing capacity problem get solved
> > > > > anytime soon, I was wondering if you are ok with putting the code
> > > > > in drivers/staging/vboxsf for now, until someone can review it and ack it
> > > > > for moving over to sf/vboxsf ?
> > > > 
> > > > I have no objection to that if the vfs developers do not mind.
> > > 
> > > We had really bad experiences with fs code in staging.  I think it is
> > > a bad idea that should not be repeated.
> > 
> > Lustre was a mistake.  erofs is better in that there are active
> > developers working to get it out of staging.  We would also need that
> > here for this to be successful.
> > 
> > Hans, is it just review that is keeping this from being merged or is
> > there "real work" that has to be done?
> 
> AFAIK it is just the reveiw which is keeping this from being merged.
> 
> During the first few revision Al Viro made some very good suggestions
> which have all been addressed, v10 was reviewed by David Howell, and the
> main thing to fix for that was switching over to the new mountfd APIs,
> v11 was also revieded by David and had some minor issues with the use
> of the new mountfd APIs. Those were all addressed for v12. So currently
> the TODO list for this fs code is empty.

Then in that case it doesn't sound like putting it in staging makes any
sense.  It should just be merged to the "correct" place right away as
nothing is left to be done on it.

thanks,

greg k-h