From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH 1/3] ext4: return the extent cache information via fiemap
Date: Sun, 11 Aug 2019 12:15:08 -0400 [thread overview]
Message-ID: <20190811161508.GA5878@mit.edu> (raw)
In-Reply-To: <20190810073343.GA12777@infradead.org>
On Sat, Aug 10, 2019 at 12:33:43AM -0700, Christoph Hellwig wrote:
>
> On Fri, Aug 09, 2019 at 02:18:29PM -0400, Theodore Ts'o wrote:
> > For debugging reasons, it's useful to know the contents of the extent
> > cache. Since the extent cache contains much of what is in the fiemap
> > ioctl, extend the fiemap interface to return this information via some
> > ext4-specific flags.
>
> Nak. No weird fs specific fiemap flags that aren't even in the uapi
> header. Please provide your own debug only interface.
I can understand why you don't like this from the principle of the
thing.
I'll create my own ioctl, and make a copy of ioctl_fiemap() into ext4
and modify it for my needs. I was trying to avoid needing to do that,
since there is plenty of space in the fiemap flags to carve out space
for file-specific specific flags, and avoiding making extra copies of
code for the purposes of reuse weighed more heavily than "no
fs-specific fiemap flags".
- Ted
next prev parent reply other threads:[~2019-08-11 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190809181831.10618-1-tytso@mit.edu>
2019-08-10 7:33 ` [PATCH 1/3] ext4: return the extent cache information via fiemap Christoph Hellwig
2019-08-11 16:15 ` Theodore Y. Ts'o [this message]
2019-08-12 6:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190811161508.GA5878@mit.edu \
--to=tytso@mit.edu \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).