From: Gao Xiang <gaoxiang25@huawei.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: Pavel Machek <pavel@denx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>, <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
<linux-erofs@lists.ozlabs.org>, Chao Yu <chao@kernel.org>,
Miao Xie <miaoxie@huawei.com>, <weidu.du@huawei.com>,
Fang Wei <fangwei1@huawei.com>
Subject: Re: [PATCH RESEND 2/2] staging: erofs: differentiate unsupported on-disk format
Date: Wed, 14 Aug 2019 17:49:43 +0800 [thread overview]
Message-ID: <20190814094943.GA17960@138> (raw)
In-Reply-To: <108ee2f9-75dd-b8ab-8da7-b81c17bafbf6@huawei.com>
Hi Chao,
On Wed, Aug 14, 2019 at 05:25:51PM +0800, Chao Yu wrote:
> On 2019/8/14 12:32, Gao Xiang wrote:
> > For some specific fields, use ENOTSUPP instead of EIO
> > for values which look sane but aren't supported right now.
> >
> > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> > + return -ENOTSUPP;
>
> A little bit confused about when we need to use ENOTSUPP or EOPNOTSUPP, I
> checked several manual of syscall, it looks EOPNOTSUPP is widely used.
It seems that you are right, I didn't notice this.
Let me resend this patchset to fix them all...
Thanks,
Gao Xiang
>
> Thanks,
next prev parent reply other threads:[~2019-08-14 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 4:25 [PATCH 1/2] staging: erofs: introduce EFSCORRUPTED and more logs Gao Xiang
2019-08-14 4:25 ` [PATCH 2/2] staging: erofs: differentiate unsupported on-disk format Gao Xiang
2019-08-14 4:32 ` [PATCH RESEND 1/2] staging: erofs: introduce EFSCORRUPTED and more logs Gao Xiang
2019-08-14 4:32 ` [PATCH RESEND 2/2] staging: erofs: differentiate unsupported on-disk format Gao Xiang
2019-08-14 9:25 ` Chao Yu
2019-08-14 9:49 ` Gao Xiang [this message]
2019-08-14 9:22 ` [PATCH RESEND 1/2] staging: erofs: introduce EFSCORRUPTED and more logs Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814094943.GA17960@138 \
--to=gaoxiang25@huawei.com \
--cc=chao@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=fangwei1@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=pavel@denx.de \
--cc=weidu.du@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).