From: Gao Xiang <gaoxiang25@huawei.com>
To: Chandan Rajendra <chandan@linux.ibm.com>
Cc: <tytso@mit.edu>, <ebiggers@kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-ext4@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-fscrypt@vger.kernel.org>, <chandanrmail@gmail.com>,
<adilger.kernel@dilger.ca>, <jaegeuk@kernel.org>,
<yuchao0@huawei.com>, <hch@infradead.org>
Subject: Re: [PATCH V4 5/8] f2fs: Use read_callbacks for decrypting file data
Date: Tue, 20 Aug 2019 13:16:36 +0800 [thread overview]
Message-ID: <20190820051635.GF159846@architecture4> (raw)
In-Reply-To: <20190820051236.GE159846@architecture4>
On Tue, Aug 20, 2019 at 01:12:36PM +0800, Gao Xiang wrote:
> Hi Chandan,
>
> On Tue, Aug 20, 2019 at 10:35:29AM +0530, Chandan Rajendra wrote:
> > On Friday, August 16, 2019 11:48 AM Chandan Rajendra wrote:
> > > F2FS has a copy of "post read processing" code using which encrypted
> > > file data is decrypted. This commit replaces it to make use of the
> > > generic read_callbacks facility.
> > >
> > > Signed-off-by: Chandan Rajendra <chandan@linux.ibm.com>
> >
> > Hi Eric and Ted,
> >
> > Looks like F2FS requires a lot more flexiblity than what can be offered by
> > read callbacks i.e.
> >
> > 1. F2FS wants to make use of its own workqueue for decryption, verity and
> > decompression.
> > 2. F2FS' decompression code is not an FS independent entity like fscrypt and
> > fsverity. Hence they would need Filesystem specific callback functions to
> > be invoked from "read callbacks".
> >
> > Hence I would suggest that we should drop F2FS changes made in this
> > patchset. Please let me know your thoughts on this.
>
> Add a word, I have some little concern about post read procession order
FYI. Just a minor concern about its flexibility, not big though.
https://lore.kernel.org/r/20190808042640.GA28630@138/
Thanks,
Gao Xiang
> a bit as I mentioned before, because I'd like to move common EROFS
> decompression code out in the future as well for other fses to use
> after we think it's mature enough.
>
> It seems the current code mainly addresses eliminating duplicated code,
> therefore I have no idea about that...
>
> Thanks,
> Gao Xiang
>
> >
> > --
> > chandan
> >
> >
> >
next prev parent reply other threads:[~2019-08-20 5:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 6:17 [PATCH V4 0/8] Consolidate FS read I/O callbacks code Chandan Rajendra
2019-08-16 6:17 ` [PATCH V4 1/8] buffer_head: Introduce BH_Read_Cb flag Chandan Rajendra
2019-08-16 6:17 ` [PATCH V4 2/8] FS: Introduce read callbacks Chandan Rajendra
2019-08-16 6:17 ` [PATCH V4 3/8] fs/mpage.c: Integrate " Chandan Rajendra
2019-08-16 6:18 ` [PATCH V4 4/8] fs/buffer.c: add decryption support via read_callbacks Chandan Rajendra
2019-08-16 6:18 ` [PATCH V4 5/8] f2fs: Use read_callbacks for decrypting file data Chandan Rajendra
2019-08-18 13:45 ` [f2fs-dev] " Chao Yu
2019-08-19 13:33 ` Chandan Rajendra
2019-08-20 7:43 ` Chao Yu
2019-08-20 5:05 ` Chandan Rajendra
2019-08-20 5:12 ` Gao Xiang
2019-08-20 5:16 ` Gao Xiang [this message]
2019-08-20 16:25 ` Theodore Y. Ts'o
2019-08-20 17:07 ` Gao Xiang
2019-08-20 16:38 ` Theodore Y. Ts'o
2019-08-20 17:31 ` Jaegeuk Kim
2019-08-21 2:04 ` Chandan Rajendra
2019-08-16 6:18 ` [PATCH V4 6/8] ext4: Wire up ext4_readpage[s] to use mpage_readpage[s] Chandan Rajendra
2019-08-16 6:18 ` [PATCH V4 7/8] ext4: Enable encryption for subpage-sized blocks Chandan Rajendra
2019-08-16 6:18 ` [PATCH V4 8/8] fscrypt: remove struct fscrypt_ctx Chandan Rajendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820051635.GF159846@architecture4 \
--to=gaoxiang25@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=chandan@linux.ibm.com \
--cc=chandanrmail@gmail.com \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).