From: Al Viro <viro@zeniv.linux.org.uk>
To: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH v2] fs: fs_parser: avoid NULL param->string to kstrtouint
Date: Thu, 22 Aug 2019 06:33:15 +0100 [thread overview]
Message-ID: <20190822053315.GM1131@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190822042249.GJ6111@zzz.localdomain>
On Wed, Aug 21, 2019 at 09:22:49PM -0700, Eric Biggers wrote:
> > > diff --git a/fs/fs_parser.c b/fs/fs_parser.c
> > > index 83b66c9e9a24..7498a44f18c0 100644
> > > --- a/fs/fs_parser.c
> > > +++ b/fs/fs_parser.c
> > > @@ -206,6 +206,9 @@ int fs_parse(struct fs_context *fc,
> > > case fs_param_is_fd: {
> > > switch (param->type) {
> > > case fs_value_is_string:
> > > + if (!result->has_value)
> > > + goto bad_value;
> > > +
> > > ret = kstrtouint(param->string, 0, &result->uint_32);
> > > break;
> > > case fs_value_is_file:
> > > --
> > > 2.17.1
> >
> > Reviewed-by: Eric Biggers <ebiggers@kernel.org>
> >
> > Al, can you please apply this patch?
> >
> > - Eric
>
> Ping. Al, when are you going to apply this?
Sits in the local queue. Sorry, got seriously sidetracked into
configfs mess lately, will update for-next tomorrow and push
it out.
prev parent reply other threads:[~2019-08-22 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 23:29 [PATCH v2] fs: fs_parser: avoid NULL param->string to kstrtouint Yin Fengwei
2019-08-16 2:46 ` Eric Biggers
2019-08-22 4:22 ` Eric Biggers
2019-08-22 5:33 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822053315.GM1131@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).