Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc5 next-20190823]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matthew-Wilcox/iomap-xfs-support-for-large-pages/20190823-191138
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/blkdev.h:16:0,
                    from include/linux/blk-cgroup.h:21,
                    from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from arch/x86/kernel/asm-offsets.c:13:
   include/linux/pagemap.h: In function 'file_offset_of_next_page':
>> include/linux/pagemap.h:445:32: error: implicit declaration of function 'compound_nr'; did you mean 'compound_order'? [-Werror=implicit-function-declaration]
     return ((loff_t)page->index + compound_nr(page)) << PAGE_SHIFT;
                                   ^~~~~~~~~~~
                                   compound_order
   include/linux/pagemap.h: In function 'i_blocks_per_page':
   include/linux/pagemap.h:659:9: error: implicit declaration of function 'page_size'; did you mean 'page_zone'? [-Werror=implicit-function-declaration]
     return page_size(page) >> inode->i_blkbits;
            ^~~~~~~~~
            page_zone
   cc1: some warnings being treated as errors
   make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2
   16 real  6 user  2 sys  56.01% cpu 	make prepare

vim +445 include/linux/pagemap.h

   435	
   436	/**
   437	 * file_offset_of_next_page - File offset of the next page.
   438	 * @page: Page cache page.
   439	 *
   440	 * Context: Any context.
   441	 * Return: The offset of the first byte after this page.
   442	 */
   443	static inline loff_t file_offset_of_next_page(struct page *page)
   444	{
 > 445		return ((loff_t)page->index + compound_nr(page)) << PAGE_SHIFT;
   446	}
   447	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation