From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03880C3A59F for ; Mon, 26 Aug 2019 11:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF25B21872 for ; Mon, 26 Aug 2019 11:53:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="h4nljASh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730462AbfHZLxQ (ORCPT ); Mon, 26 Aug 2019 07:53:16 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33842 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbfHZLxQ (ORCPT ); Mon, 26 Aug 2019 07:53:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lZnBdyi3U2JinlfRXPGTK6Ot4IAtObs74Nrk19Et59I=; b=h4nljASh9KzABQmHDW5KPiI5y rYfaQ9ckmtTLidzXqdVCp0kF98xjf4iYIvzChMQ+kZPX5dFnceTCsbzUIUgXzefxzhTIey+QON6E3 HdKAyQOYx2zGew4MWxorz2O/U4UXjDKU8vLrNzb/YCEO23oqRpsSvaQ+xzPFCXiGigwnO51UQU8Ng c2nipNf141NY7vJYW1pgnwmI3CJ2N2UQXsUkB8/CWGoqHPEmwsC99YcpjCUNrRkng2qqYkxwezrRV bdEm2DiIK+AbKnMruJeHndTGfb4h0UTWaRATbqcGJPhWonnBXPiaTIWTzgA5TCnXYX7nZzgLDuvGR A5CXgO69w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i2DYi-0008I5-1i; Mon, 26 Aug 2019 11:53:16 +0000 Date: Mon, 26 Aug 2019 04:53:16 -0700 From: Christoph Hellwig To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, virtio-fs@redhat.com, miklos@szeredi.hu, stefanha@redhat.com, dgilbert@redhat.com, Dan Williams Subject: Re: [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range() Message-ID: <20190826115316.GB21051@infradead.org> References: <20190821175720.25901-1-vgoyal@redhat.com> <20190821175720.25901-3-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821175720.25901-3-vgoyal@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Aug 21, 2019 at 01:57:03PM -0400, Vivek Goyal wrote: > Right now dax_writeback_mapping_range() is passed a bdev and dax_dev > is searched from that bdev name. > > virtio-fs does not have a bdev. So pass in dax_dev also to > dax_writeback_mapping_range(). If dax_dev is passed in, bdev is not > used otherwise dax_dev is searched using bdev. Please just pass in only the dax_device and get rid of the block device. The callers should have one at hand easily, e.g. for XFS just call xfs_find_daxdev_for_inode instead of xfs_find_bdev_for_inode.